From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: rip out unnecessary calls to drm_mode_set_crtcinfo Date: Tue, 24 Apr 2012 16:11:43 +0100 Message-ID: <1335280337_38538@CP5-2952> References: <1335274897-18352-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id E94B5A0AD2 for ; Tue, 24 Apr 2012 08:12:20 -0700 (PDT) In-Reply-To: <1335274897-18352-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Tue, 24 Apr 2012 15:41:37 +0200, Daniel Vetter wrote: > the only places we actually need the crtc timings is in the mode_set > function. > > So we can now safely rip out all the remaining calls to set_crtcinfo > left in the driver and clean up this confusion. I have a little flicker of doubt because these tend to end up being passed into the core drm as well as used during modeset. Even looking through the instances of drm_mode_set_crtcinfo() in the core, I'm left no the wiser as to which functions expect crtc_* to be filled in. As far I can see the only place where set_crtcinfo() must be called is prior to the final modeset, and so the crtc_* values are only ever used on the adjusted_mode. Hence why the drm usage leaves me slightly puzzled. -Chris -- Chris Wilson, Intel Open Source Technology Centre