Re: [PATCH v4 1/8] libxl: make libxl_device_disk_local_attach/detach internal functions

From: Ian Campbell <Ian.Campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH v4 1/8] libxl: make libxl_device_disk_local_attach/detach internal functions
Date: Tue, 24 Apr 2012 16:16:40 +0100	[thread overview]
Message-ID: <1335280600.4347.201.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <1335264358-20182-1-git-send-email-stefano.stabellini@eu.citrix.com>

On Tue, 2012-04-24 at 11:45 +0100, Stefano Stabellini wrote:

No functional change other than ctx->gc?

> diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c
> index b89aef7..1f428b2 100644
> --- a/tools/libxl/libxl_internal.c
> +++ b/tools/libxl/libxl_internal.c
> @@ -323,6 +323,78 @@ out:
>      return rc;
>  }
>  
> +_hidden char * libxl__device_disk_local_attach(libxl__gc *gc, libxl_device_disk *disk)

Strictly the hidden is only needed on the prototype. I guess there's no
harm having it here too (but you know what linkers are like...)

> +{
[...]
> +}

Looking at the callers this could possibly be a gc'd string, and perhaps
const in the return here. That's for another day though I think.

Acked-by: Ian Campbell <ian.campbell@citrix.com>