From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephan Mueller Subject: Re: [PATCH 0/2] crypto: add new driver for Marvell CESA Date: Thu, 09 Apr 2015 17:52:42 +0200 Message-ID: <13353890.ylqfTNBYXC@tauon> References: <1428591523-1780-1-git-send-email-boris.brezillon@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, Tawfik Bayouk , Lior Amsalem , Nadav Haklai , Eran Ben-Avi , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnaud Ebalard To: Boris Brezillon Return-path: Received: from mail.eperm.de ([89.247.134.16]:34058 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753479AbbDIPwp (ORCPT ); Thu, 9 Apr 2015 11:52:45 -0400 In-Reply-To: <1428591523-1780-1-git-send-email-boris.brezillon@free-electrons.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: Am Donnerstag, 9. April 2015, 16:58:41 schrieb Boris Brezillon: Hi Boris, >Hello, > >This is an attempt to replace the mv_cesa driver by a new one to address >some limitations of the existing driver. >>From a performance and CPU load point of view the most important >limitation is the lack of DMA support, thus preventing us from chaining >crypto operations. > >I know we usually try to adapt existing drivers instead of replacing them >by new ones, but after trying to refactor the mv_cesa driver I realized it >would take longer than writing an new one from scratch. > >Here are the main features brought by this new driver: >- support for armada SoCs (up to 38x) while keeping support for older ones > (Orion and Kirkwood) >- DMA mode to offload the CPU in case of intensive crypto usage >- new algorithms: SHA256, DES and 3DES > >I'd like to thank Arnaud, who has carefully reviewed several iterations of >this driver, helped me improved my implementation, provided support for >several crypto algorithms, provided support for armada-370 and tested >the driver on different platforms, hence the SoB and dual MODULE_AUTHOR >in the driver code. Your patch 1/2 did not make it to the crypto list. To big? It is on the lkml list though. > >Best Regards, > >Boris > >Boris Brezillon (2): > crypto: add new driver for Marvell CESA > crypto: marvell/CESA: update DT bindings documentation > > .../devicetree/bindings/crypto/mv_cesa.txt | 50 +- > drivers/crypto/Kconfig | 2 + > drivers/crypto/Makefile | 2 +- > drivers/crypto/marvell/Makefile | 1 + > drivers/crypto/marvell/cesa.c | 539 ++++++++ > drivers/crypto/marvell/cesa.h | 802 ++++++++++++ > drivers/crypto/marvell/cipher.c | 761 +++++++++++ > drivers/crypto/marvell/hash.c | 1349 >++++++++++++++++++++ drivers/crypto/marvell/tdma.c | >223 ++++ > drivers/crypto/mv_cesa.c | 1193 ----------------- > drivers/crypto/mv_cesa.h | 150 --- > 11 files changed, 3716 insertions(+), 1356 deletions(-) > create mode 100644 drivers/crypto/marvell/Makefile > create mode 100644 drivers/crypto/marvell/cesa.c > create mode 100644 drivers/crypto/marvell/cesa.h > create mode 100644 drivers/crypto/marvell/cipher.c > create mode 100644 drivers/crypto/marvell/hash.c > create mode 100644 drivers/crypto/marvell/tdma.c > delete mode 100644 drivers/crypto/mv_cesa.c > delete mode 100644 drivers/crypto/mv_cesa.h Ciao Stephan From mboxrd@z Thu Jan 1 00:00:00 1970 From: smueller@chronox.de (Stephan Mueller) Date: Thu, 09 Apr 2015 17:52:42 +0200 Subject: [PATCH 0/2] crypto: add new driver for Marvell CESA In-Reply-To: <1428591523-1780-1-git-send-email-boris.brezillon@free-electrons.com> References: <1428591523-1780-1-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <13353890.ylqfTNBYXC@tauon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Donnerstag, 9. April 2015, 16:58:41 schrieb Boris Brezillon: Hi Boris, >Hello, > >This is an attempt to replace the mv_cesa driver by a new one to address >some limitations of the existing driver. >>From a performance and CPU load point of view the most important >limitation is the lack of DMA support, thus preventing us from chaining >crypto operations. > >I know we usually try to adapt existing drivers instead of replacing them >by new ones, but after trying to refactor the mv_cesa driver I realized it >would take longer than writing an new one from scratch. > >Here are the main features brought by this new driver: >- support for armada SoCs (up to 38x) while keeping support for older ones > (Orion and Kirkwood) >- DMA mode to offload the CPU in case of intensive crypto usage >- new algorithms: SHA256, DES and 3DES > >I'd like to thank Arnaud, who has carefully reviewed several iterations of >this driver, helped me improved my implementation, provided support for >several crypto algorithms, provided support for armada-370 and tested >the driver on different platforms, hence the SoB and dual MODULE_AUTHOR >in the driver code. Your patch 1/2 did not make it to the crypto list. To big? It is on the lkml list though. > >Best Regards, > >Boris > >Boris Brezillon (2): > crypto: add new driver for Marvell CESA > crypto: marvell/CESA: update DT bindings documentation > > .../devicetree/bindings/crypto/mv_cesa.txt | 50 +- > drivers/crypto/Kconfig | 2 + > drivers/crypto/Makefile | 2 +- > drivers/crypto/marvell/Makefile | 1 + > drivers/crypto/marvell/cesa.c | 539 ++++++++ > drivers/crypto/marvell/cesa.h | 802 ++++++++++++ > drivers/crypto/marvell/cipher.c | 761 +++++++++++ > drivers/crypto/marvell/hash.c | 1349 >++++++++++++++++++++ drivers/crypto/marvell/tdma.c | >223 ++++ > drivers/crypto/mv_cesa.c | 1193 ----------------- > drivers/crypto/mv_cesa.h | 150 --- > 11 files changed, 3716 insertions(+), 1356 deletions(-) > create mode 100644 drivers/crypto/marvell/Makefile > create mode 100644 drivers/crypto/marvell/cesa.c > create mode 100644 drivers/crypto/marvell/cesa.h > create mode 100644 drivers/crypto/marvell/cipher.c > create mode 100644 drivers/crypto/marvell/hash.c > create mode 100644 drivers/crypto/marvell/tdma.c > delete mode 100644 drivers/crypto/mv_cesa.c > delete mode 100644 drivers/crypto/mv_cesa.h Ciao Stephan