From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753876Ab2D2QDd (ORCPT ); Sun, 29 Apr 2012 12:03:33 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:55780 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752524Ab2D2QDc (ORCPT ); Sun, 29 Apr 2012 12:03:32 -0400 Message-ID: <1335715408.12022.7.camel@joe2Laptop> Subject: Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers From: Joe Perches To: Mauro Carvalho Chehab Cc: Borislav Petkov , Linux Edac Mailing List , Linux Kernel Mailing List , Aristeu Rozanski , Doug Thompson , Mark Gross , Jason Uhlenkott , Tim Small , "Arvind R." , Olof Johansson , Egor Martovetsky , Chris Metcalf , Michal Marek , Jiri Kosina , Dmitry Eremin-Solenikov , Benjamin Herrenschmidt , Hitoshi Mitake , Andrew Morton , Niklas =?ISO-8859-1?Q?S=F6derlund?= , Shaohui Xie , Josh Boyer , linuxppc-dev@lists.ozlabs.org Date: Sun, 29 Apr 2012 09:03:28 -0700 In-Reply-To: <4F9D5A2E.2030506@redhat.com> References: <1335289087-11337-1-git-send-email-mchehab@redhat.com> <1335291342-14922-1-git-send-email-mchehab@redhat.com> <20120427133304.GE9626@aftab.osrc.amd.com> <1335535895.25521.7.camel@joe2Laptop> <4F9AC44A.5000509@redhat.com> <20120428085223.GB26065@aftab.osrc.amd.com> <4F9D4F6E.4070106@redhat.com> <4F9D5A2E.2030506@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2012-04-29 at 12:11 -0300, Mauro Carvalho Chehab wrote: > Em 29-04-2012 11:25, Mauro Carvalho Chehab escreveu: > > Em 28-04-2012 05:52, Borislav Petkov escreveu: > >> On Fri, Apr 27, 2012 at 01:07:38PM -0300, Mauro Carvalho Chehab wrote: > >>> Yes. This is a common issue at the EDAC core: on several places, it calls the > >>> edac debug macros (DEBUGF0...DEBUGF4) passing a __func__ as an argument, while > >>> the debug macros already handles that. I suspect that, in the past, the __func__ > >>> were not at the macros, but some patch added it there, and forgot to fix the > >>> occurrences of its call. > >> The patch that added it is d357cbb445208 and you reviewed it. > > And you wrote the patch that caused it. And Boris should have also written the follow-on patches that removed most/all of the debugfX and __func__ uses. > > A single patch fixing this everywhere at drivers/edac is better and clearer than adding > > an unrelated fix on this patch. This is already complex enough to add more unrelated > > things there. > > > > Also, a simple perl/coccinelle script can replace all such __func__ occurrences > > on one shot. You make it sound simple, but it'd be a pretty complicated cocci script. Some of the changes would have to be inspected or changed by hand in any case. [] > Most of the issues can be solved with the above script-based patch. > > There are still 171 places (12 places at the core, the rest are on the drivers) > that will require a more sophisticated patch or that requires a manual fix. [] > From: Mauro Carvalho Chehab > Date: Sun, 29 Apr 2012 11:59:14 -0300 > Subject: [PATCH] edac: Don't add __func__ or __FILE__ for debugf[0-9] msgs Thanks Mauro, you shouldn't have had to do this. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from labridge.com (perches-mx.perches.com [206.117.179.246]) (using SSLv3 with cipher DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4DABAB6FE9 for ; Mon, 30 Apr 2012 02:03:33 +1000 (EST) Message-ID: <1335715408.12022.7.camel@joe2Laptop> Subject: Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers From: Joe Perches To: Mauro Carvalho Chehab Date: Sun, 29 Apr 2012 09:03:28 -0700 In-Reply-To: <4F9D5A2E.2030506@redhat.com> References: <1335289087-11337-1-git-send-email-mchehab@redhat.com> <1335291342-14922-1-git-send-email-mchehab@redhat.com> <20120427133304.GE9626@aftab.osrc.amd.com> <1335535895.25521.7.camel@joe2Laptop> <4F9AC44A.5000509@redhat.com> <20120428085223.GB26065@aftab.osrc.amd.com> <4F9D4F6E.4070106@redhat.com> <4F9D5A2E.2030506@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: Shaohui Xie , Jason Uhlenkott , Aristeu Rozanski , Hitoshi Mitake , Mark Gross , Dmitry Eremin-Solenikov , Borislav Petkov , Egor Martovetsky , Niklas =?ISO-8859-1?Q?S=F6derlund?= , Tim Small , "Arvind R." , Chris Metcalf , Doug Thompson , Linux Edac Mailing List , Michal Marek , Jiri Kosina , Linux Kernel Mailing List , Olof Johansson , Andrew Morton , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, 2012-04-29 at 12:11 -0300, Mauro Carvalho Chehab wrote: > Em 29-04-2012 11:25, Mauro Carvalho Chehab escreveu: > > Em 28-04-2012 05:52, Borislav Petkov escreveu: > >> On Fri, Apr 27, 2012 at 01:07:38PM -0300, Mauro Carvalho Chehab wrote: > >>> Yes. This is a common issue at the EDAC core: on several places, it calls the > >>> edac debug macros (DEBUGF0...DEBUGF4) passing a __func__ as an argument, while > >>> the debug macros already handles that. I suspect that, in the past, the __func__ > >>> were not at the macros, but some patch added it there, and forgot to fix the > >>> occurrences of its call. > >> The patch that added it is d357cbb445208 and you reviewed it. > > And you wrote the patch that caused it. And Boris should have also written the follow-on patches that removed most/all of the debugfX and __func__ uses. > > A single patch fixing this everywhere at drivers/edac is better and clearer than adding > > an unrelated fix on this patch. This is already complex enough to add more unrelated > > things there. > > > > Also, a simple perl/coccinelle script can replace all such __func__ occurrences > > on one shot. You make it sound simple, but it'd be a pretty complicated cocci script. Some of the changes would have to be inspected or changed by hand in any case. [] > Most of the issues can be solved with the above script-based patch. > > There are still 171 places (12 places at the core, the rest are on the drivers) > that will require a more sophisticated patch or that requires a manual fix. [] > From: Mauro Carvalho Chehab > Date: Sun, 29 Apr 2012 11:59:14 -0300 > Subject: [PATCH] edac: Don't add __func__ or __FILE__ for debugf[0-9] msgs Thanks Mauro, you shouldn't have had to do this.