From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS38C-00063P-Ez for qemu-devel@nongnu.org; Wed, 09 May 2012 05:24:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SS383-00025m-JB for qemu-devel@nongnu.org; Wed, 09 May 2012 05:24:24 -0400 Received: from mx.meyering.net ([88.168.87.75]:36916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS383-000242-Bq for qemu-devel@nongnu.org; Wed, 09 May 2012 05:24:15 -0400 From: Jim Meyering Date: Wed, 9 May 2012 11:23:49 +0200 Message-Id: <1336555446-20180-6-git-send-email-jim@meyering.net> In-Reply-To: <1336555446-20180-1-git-send-email-jim@meyering.net> References: <1336555446-20180-1-git-send-email-jim@meyering.net> Subject: [Qemu-devel] [PATCH 05/22] lm32: avoid buffer overrun List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jim Meyering , Anthony Liguori From: Jim Meyering Actually do what the comment says, using pstrcpy to NUL-terminate: strncpy does not always do that. Signed-off-by: Jim Meyering --- hw/lm32_hwsetup.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/lm32_hwsetup.h b/hw/lm32_hwsetup.h index 8fc285e..70dc61f 100644 --- a/hw/lm32_hwsetup.h +++ b/hw/lm32_hwsetup.h @@ -96,7 +96,7 @@ static inline void hwsetup_add_tag(HWSetup *hw, enum hwsetup_tag t) static inline void hwsetup_add_str(HWSetup *hw, const char *str) { - strncpy(hw->ptr, str, 31); /* make sure last byte is zero */ + pstrcpy(hw->ptr, 32, str); hw->ptr += 32; } -- 1.7.10.1.487.ga3935e6