From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760154Ab2EJPeQ (ORCPT ); Thu, 10 May 2012 11:34:16 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:53568 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757029Ab2EJPeN (ORCPT ); Thu, 10 May 2012 11:34:13 -0400 From: Joonsoo Kim To: Pekka Enberg Cc: Christoph Lameter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim Subject: [PATCH] slub: fix a possible memory leak Date: Fri, 11 May 2012 00:32:59 +0900 Message-Id: <1336663979-2611-1-git-send-email-js1304@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Memory allocated by kstrdup should be freed, when kmalloc(kmem_size, GFP_KERNEL) is failed. Signed-off-by: Joonsoo Kim diff --git a/mm/slub.c b/mm/slub.c index 23d66aa..9c920a0 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -3968,9 +3968,9 @@ struct kmem_cache *kmem_cache_create(const char *name, size_t size, } return s; } - kfree(n); kfree(s); } + kfree(n); err: up_write(&slub_lock); -- 1.7.9.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx133.postini.com [74.125.245.133]) by kanga.kvack.org (Postfix) with SMTP id E6BB06B00F8 for ; Thu, 10 May 2012 11:34:13 -0400 (EDT) Received: by mail-pz0-f41.google.com with SMTP id p5so2565828dak.14 for ; Thu, 10 May 2012 08:34:13 -0700 (PDT) From: Joonsoo Kim Subject: [PATCH] slub: fix a possible memory leak Date: Fri, 11 May 2012 00:32:59 +0900 Message-Id: <1336663979-2611-1-git-send-email-js1304@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: Christoph Lameter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim Memory allocated by kstrdup should be freed, when kmalloc(kmem_size, GFP_KERNEL) is failed. Signed-off-by: Joonsoo Kim diff --git a/mm/slub.c b/mm/slub.c index 23d66aa..9c920a0 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -3968,9 +3968,9 @@ struct kmem_cache *kmem_cache_create(const char *name, size_t size, } return s; } - kfree(n); kfree(s); } + kfree(n); err: up_write(&slub_lock); -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org