From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756102Ab2EJUhJ (ORCPT ); Thu, 10 May 2012 16:37:09 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:44424 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751459Ab2EJUhH (ORCPT ); Thu, 10 May 2012 16:37:07 -0400 Message-ID: <1336682226.29763.2.camel@joe2Laptop> Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer From: Joe Perches To: "Ted Ts'o" Cc: Kay Sievers , Linus Torvalds , Ingo Molnar , Jonathan Corbet , Sasha Levin , Greg Kroah-Hartmann , linux-kernel@vger.kernel.org Date: Thu, 10 May 2012 13:37:06 -0700 In-Reply-To: <20120510201409.GA6467@thunk.org> References: <20120509070710.GA29981@gmail.com> <1336611278.728.9.camel@mop> <1336667984.947.24.camel@mop> <1336676986.947.47.camel@mop> <20120510201409.GA6467@thunk.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-05-10 at 16:14 -0400, Ted Ts'o wrote: > Is there any difference in any of the cases in terms of how printk's > that are prefixed with KERN_CONT versus a printk that does not have > any KERN_* prefix? If so, is there value in keeping KERN_CONT? As far as I know, no. It is a useful marker to show where prints are actually continued. #define KERN_CONT "" would save a small amount of text.