From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on
 server CPUs
Date: Fri, 11 May 2012 07:43:35 +1000
Message-ID: <1336686215.3881.56.camel@pasglop>
References: <1335505422.4578.3.camel@pasglop>
	 <1335505900.4578.9.camel@pasglop> <4FABFFAD.3040602@suse.de>
	 <4FAC0118.9040908@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Alexander Graf <agraf@suse.de>, kvm@vger.kernel.org,
	kvm-ppc <kvm-ppc@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <4FAC0118.9040908@redhat.com>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Thu, 2012-05-10 at 20:55 +0300, Avi Kivity wrote:
> On 05/10/2012 08:49 PM, Alexander Graf wrote:
> >> +#if defined(TARGET_PPC64)
> >> +    if (def->sps)
> >> +        memcpy(&env->sps, def->sps, sizeof(*def->sps));
> >
> >
> > I never know if *def->... would dereference def or the complete
> > construct. 
> 
> 'man operator'
> 
> > How about sizeof(env->sps)?
> 
> How about
> 
>   env->sps = *def->sps;

Yeah, latter looks better doesn't it ? :-)

I'll change that when I respin.

Cheers,
Ben.

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Thu, 10 May 2012 21:43:35 +0000
Subject: Re: [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs
Message-Id: <1336686215.3881.56.camel@pasglop>
List-Id: <kvm-ppc.vger.kernel.org>
References: <1335505422.4578.3.camel@pasglop>
	 <1335505900.4578.9.camel@pasglop> <4FABFFAD.3040602@suse.de>
	 <4FAC0118.9040908@redhat.com>
In-Reply-To: <4FAC0118.9040908@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Avi Kivity <avi@redhat.com>
Cc: Alexander Graf <agraf@suse.de>, kvm@vger.kernel.org, kvm-ppc <kvm-ppc@vger.kernel.org>

On Thu, 2012-05-10 at 20:55 +0300, Avi Kivity wrote:
> On 05/10/2012 08:49 PM, Alexander Graf wrote:
> >> +#if defined(TARGET_PPC64)
> >> +    if (def->sps)
> >> +        memcpy(&env->sps, def->sps, sizeof(*def->sps));
> >
> >
> > I never know if *def->... would dereference def or the complete
> > construct. 
> 
> 'man operator'
> 
> > How about sizeof(env->sps)?
> 
> How about
> 
>   env->sps = *def->sps;

Yeah, latter looks better doesn't it ? :-)

I'll change that when I respin.

Cheers,
Ben.