From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754924Ab2EKANW (ORCPT ); Thu, 10 May 2012 20:13:22 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:45705 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751676Ab2EKANU (ORCPT ); Thu, 10 May 2012 20:13:20 -0400 Message-ID: <1336695199.29763.28.camel@joe2Laptop> Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer From: Joe Perches To: Linus Torvalds Cc: Kay Sievers , "Ted Ts'o" , Ingo Molnar , Jonathan Corbet , Sasha Levin , Greg Kroah-Hartmann , linux-kernel@vger.kernel.org Date: Thu, 10 May 2012 17:13:19 -0700 In-Reply-To: References: <20120509070710.GA29981@gmail.com> <1336611278.728.9.camel@mop> <1336667984.947.24.camel@mop> <1336676986.947.47.camel@mop> <20120510201409.GA6467@thunk.org> <1336682226.29763.2.camel@joe2Laptop> <1336682772.29763.6.camel@joe2Laptop> <1336684277.29763.12.camel@joe2Laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-05-10 at 14:58 -0700, Linus Torvalds wrote: > On Thu, May 10, 2012 at 2:11 PM, Joe Perches wrote: > > > > I think it's a distinction without a difference for, > > as fas as I know, that's a case that doesn't exist > > in the current kernel. > > So? Even if we hadn't had this bug before (we have), True. I've fixed the ones you've introduced when you changed printk semantics in the past. > your argument is utter crap. What happened to the pragmatic Linus Torvalds? Did the dogmatic one replace him again temporarily? > Even if we weren't to have that patter right *now*, that > doesn't mean that it cannot happen. Not what I said. > Your grep is also not at all exhaustive. I believe I know the printk subsystem and its uses as well as anyone. I don't think there is a case today. > We do need an escape model. Or an agreement to not to emit "<[0-7cd]>" as the first 3 bytes after a newline or as the start of a new printk. It could just as easily be an escape is a required leading non "<" character. I think that's not onerous. > The current KERN_CONT does that. Stop > arguing for crap. Correctness in all cases can be a good thing. Simplicity may be better because complexity is reduced. cheers, Joe