From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUXAk-0003vG-SS for qemu-devel@nongnu.org; Wed, 16 May 2012 01:53:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUXAi-0002Bg-Oj for qemu-devel@nongnu.org; Wed, 16 May 2012 01:53:18 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:48802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUXAi-0002BA-Hg for qemu-devel@nongnu.org; Wed, 16 May 2012 01:53:16 -0400 From: Stefan Weil Date: Wed, 16 May 2012 07:53:13 +0200 Message-Id: <1337147593-20587-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH 1.1] kvm: Fix wrong size in memset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Jan Kiszka , qemu-devel@nongnu.org, Stefan Weil Only the first 4 or 8 bytes were set to 0. This bug was found by cppcheck. Signed-off-by: Stefan Weil --- hw/kvm/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/kvm/apic.c b/hw/kvm/apic.c index ffe7a52..a0ab503 100644 --- a/hw/kvm/apic.c +++ b/hw/kvm/apic.c @@ -29,7 +29,7 @@ void kvm_put_apic_state(DeviceState *d, struct kvm_lapic_state *kapic) APICCommonState *s = DO_UPCAST(APICCommonState, busdev.qdev, d); int i; - memset(kapic, 0, sizeof(kapic)); + memset(kapic, 0, sizeof(*kapic)); kvm_apic_set_reg(kapic, 0x2, s->id << 24); kvm_apic_set_reg(kapic, 0x8, s->tpr); kvm_apic_set_reg(kapic, 0xd, s->log_dest << 24); -- 1.7.10