All of lore.kernel.org
 help / color / mirror / Atom feed
From: ville.syrjala@linux.intel.com
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH 4/6] drm/i915: Check the framebuffer offset
Date: Thu, 24 May 2012 21:08:57 +0300	[thread overview]
Message-ID: <1337882939-22274-5-git-send-email-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <1337882939-22274-1-git-send-email-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The framebuffer offset must be aligned to (macro)pixel size.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_display.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 8fea475..9df15ee 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -6660,6 +6660,7 @@ int intel_framebuffer_init(struct drm_device *dev,
 			   struct drm_i915_gem_object *obj)
 {
 	int ret;
+	unsigned int align = drm_format_plane_cpp(mode_cmd->pixel_format, 0);
 
 	if (obj->tiling_mode == I915_TILING_Y)
 		return -EINVAL;
@@ -6699,6 +6700,7 @@ int intel_framebuffer_init(struct drm_device *dev,
 	case DRM_FORMAT_UYVY:
 	case DRM_FORMAT_YVYU:
 	case DRM_FORMAT_VYUY:
+		align <<= 1;
 		if (INTEL_INFO(dev)->gen < 6)
 			return -EINVAL;
 		break;
@@ -6707,6 +6709,9 @@ int intel_framebuffer_init(struct drm_device *dev,
 		return -EINVAL;
 	}
 
+	if (mode_cmd->offsets[0] % align)
+		return -EINVAL;
+
 	ret = drm_framebuffer_init(dev, &intel_fb->base, &intel_fb_funcs);
 	if (ret) {
 		DRM_ERROR("framebuffer init failed %d\n", ret);
-- 
1.7.3.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2012-05-24 18:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24 18:08 [PATCH 0/6] drm/i915: Framebuffer layout fixes and sanity checks ville.syrjala
2012-05-24 18:08 ` [PATCH 1/6] drm/i915: Fix display pixel format handling ville.syrjala
2012-05-24 18:08 ` [PATCH 2/6] drm/i915: Check framebuffer stride more thoroughly ville.syrjala
2012-07-05 11:27   ` Daniel Vetter
2012-07-05 11:59     ` [Intel-gfx] " Ville Syrjälä
2012-05-24 18:08 ` [PATCH 3/6] drm/i915: Zero initialize mode_cmd ville.syrjala
2012-07-05 11:28   ` Daniel Vetter
2012-05-24 18:08 ` ville.syrjala [this message]
2012-05-24 18:08 ` [PATCH 5/6] drm/i915: Handle framebuffer offsets[] ville.syrjala
2012-05-24 18:31   ` Jesse Barnes
2012-05-24 18:49     ` Ville Syrjälä
2012-05-24 19:01       ` [Intel-gfx] " Daniel Vetter
2012-07-05 11:29         ` Daniel Vetter
2012-07-05 12:01           ` [Intel-gfx] " Ville Syrjälä
2012-05-24 18:08 ` [PATCH 6/6] drm/i915: Reject page flips with changed format/offset/pitch ville.syrjala
2012-07-05 11:31   ` [Intel-gfx] " Daniel Vetter
2012-07-19 12:27     ` Laurent Pinchart
2012-07-19 12:39       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337882939-22274-5-git-send-email-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.