From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 0 of 5 V2] libxl: make it possible to explicitly specify default sched params Date: Fri, 1 Jun 2012 19:47:50 +0100 Message-ID: <1338576470.14877.58.camel@dagon.hellion.org.uk> References: <1338548826.17466.88.camel@zakaz.uk.xensource.com> <20425.1295.7385.342986@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20425.1295.7385.342986@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: George Dunlap , Dario Faggioli , Juergen Gross , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Fri, 2012-06-01 at 19:08 +0100, Ian Jackson wrote: > Ian Campbell writes ("Re: [Xen-devel] [PATCH 0 of 5 V2] libxl: make it possible to explicitly specify default sched params"): > > On Tue, 2012-05-29 at 14:56 +0100, Ian Campbell wrote: > > > This series defines a descriminating value for each scheduler paramter > > > and uses it to fix a warning when starting a guest: > > > "Cpu weight out of range, valid values are within range from 1 to 65535" > > > > I applied this with George and Ian J's acks. > > It seems to have produced a build failure in the ocaml bindings. Damn, sorry about that. I swear I compiled this both before sending it and as part of the commit procedure, and I just tried built it again and didn't see it. However I've now done a make clean and can now repro. Patch to follow shortly. > See > below. > > Ian. > > make[7]: Entering directory `/u/iwj/work/xen-unstable-tools.hg/tools/ocaml/libs/xl' > MLC xenlight.cmo > MLA xenlight.cma > CC xenlight_stubs.o > xenlight_stubs.c: In function 'stub_xl_sched_credit_domain_get': > xenlight_stubs.c:503: error: 'libxl_sched_credit_domain' undeclared (first use in this function) > xenlight_stubs.c:503: error: (Each undeclared identifier is reported only once > xenlight_stubs.c:503: error: for each function it appears in.) > xenlight_stubs.c:503: error: expected ';' before 'c_scinfo' > cc1: warnings being treated as errors > xenlight_stubs.c:504: error: ISO C90 forbids mixed declarations and code > xenlight_stubs.c:508: error: implicit declaration of function 'libxl_sched_credit_domain_get' > xenlight_stubs.c:508: error: 'c_scinfo' undeclared (first use in this function) > xenlight_stubs.c:513: error: implicit declaration of function 'Val_sched_credit_domain' > xenlight_stubs.c: In function 'stub_xl_sched_credit_domain_set': > xenlight_stubs.c:520: error: 'libxl_sched_credit_domain' undeclared (first use in this function) > xenlight_stubs.c:520: error: expected ';' before 'c_scinfo' > xenlight_stubs.c:521: error: ISO C90 forbids mixed declarations and code > xenlight_stubs.c:524: error: implicit declaration of function 'sched_credit_domain_val' > xenlight_stubs.c:524: error: 'c_scinfo' undeclared (first use in this function) > xenlight_stubs.c:527: error: implicit declaration of function 'libxl_sched_credit_domain_set' > make[7]: *** [xenlight_stubs.o] Error 1 > make[7]: Leaving directory `/u/iwj/work/xen-unstable-tools.hg/tools/ocaml/libs/xl' > make[6]: *** [subdir-install-xl] Error 2 > make[6]: Leaving directory `/u/iwj/work/xen-unstable-tools.hg/tools/ocaml/libs' > make[5]: *** [subdirs-install] Error 2 > make[5]: Leaving directory `/u/iwj/work/xen-unstable-tools.hg/tools/ocaml/libs' > make[4]: *** [subdir-install-libs] Error 2 > make[4]: Leaving directory `/u/iwj/work/xen-unstable-tools.hg/tools/ocaml' > make[3]: *** [subdirs-install] Error 2 > make[3]: Leaving directory `/u/iwj/work/xen-unstable-tools.hg/tools/ocaml' > make[2]: *** [subdir-install-ocaml] Error 2 > make[2]: Leaving directory `/u/iwj/work/xen-unstable-tools.hg/tools' > make[1]: *** [subdirs-install] Error 2 > make[1]: Leaving directory `/u/iwj/work/xen-unstable-tools.hg/tools' > make: *** [install-tools] Error 2