From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Seoh8-0004pN-Ae for qemu-devel@nongnu.org; Wed, 13 Jun 2012 10:37:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Seoh3-0001wW-BQ for qemu-devel@nongnu.org; Wed, 13 Jun 2012 10:37:13 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:50041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Seoh3-0001rj-0n for qemu-devel@nongnu.org; Wed, 13 Jun 2012 10:37:09 -0400 Received: by mail-pz0-f45.google.com with SMTP id n2so62418dad.4 for ; Wed, 13 Jun 2012 07:37:08 -0700 (PDT) Sender: Dong Xu Wang From: Dong Xu Wang Date: Wed, 13 Jun 2012 22:36:27 +0800 Message-Id: <1339598189-17933-4-git-send-email-wdongxu@linux.vnet.ibm.com> In-Reply-To: <1339598189-17933-1-git-send-email-wdongxu@linux.vnet.ibm.com> References: <1339598189-17933-1-git-send-email-wdongxu@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, Dong Xu Wang add-cow file can't live alone, must together will image_file and backing_file. If we implement qemu-img convert operation for add-cow file format, we must create image_file and backing_file manually, that will be confused for users, so we just ignore add-cow format while doing converting. Signed-off-by: Dong Xu Wang --- qemu-img.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index c8a70ff..0bce61c 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -756,6 +756,12 @@ static int img_convert(int argc, char **argv) } } + if (strcmp(out_fmt, "add-cow") == 0) { + error_report("Convert operation does not support %s format.", out_fmt); + ret = -1; + goto out; + } + /* Find driver and parse its options */ drv = bdrv_find_format(out_fmt); if (!drv) { -- 1.7.1