From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18627C433FE for ; Tue, 19 Oct 2021 08:33:25 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 193C561264 for ; Tue, 19 Oct 2021 08:33:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 193C561264 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=oktetlabs.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B03140683; Tue, 19 Oct 2021 10:33:23 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 78CAD4003E for ; Tue, 19 Oct 2021 10:33:22 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 041707F5B3; Tue, 19 Oct 2021 11:33:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 041707F5B3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634632402; bh=YK1i8G0j5bNzU/cxTm2AgnfwXWgBckMWEmtXneoRB1I=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=WfnDB2UXfWefiKXhmL8NutYTjAfrX3qDiA+TD28GPF20JaowzcRrIa4+N2F3qcHWJ idyHfnCqRl3UzXClYNCxbLDWLmZtfrkPoKzTlbHJA5HB2x4Y0umW2M7c+SIxaBemKa U9M8n/EqB6I0lcW8DZe71zS1iwbbDLXAoTql+d1k= To: Xueming Li , dev@dpdk.org, Zhang Yuying Cc: Jerin Jacob , Ferruh Yigit , Viacheslav Ovsiienko , Thomas Monjalon , Lior Margalit , Ananyev Konstantin , Ajit Khaparde , Xiaoyun Li References: <20210727034204.20649-1-xuemingl@nvidia.com> <20211019081738.2165150-1-xuemingl@nvidia.com> <20211019081738.2165150-3-xuemingl@nvidia.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <1339af28-46bf-39ff-094d-1ae5052fa80d@oktetlabs.ru> Date: Tue, 19 Oct 2021 11:33:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211019081738.2165150-3-xuemingl@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9 2/6] app/testpmd: dump device capability and Rx domain info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/21 11:17 AM, Xueming Li wrote: > Dump device capability and Rx domain ID if shared Rx queue is supported > by device. > > Signed-off-by: Xueming Li LGTM except one minor note: Acked-by: Andrew Rybchenko > --- > app/test-pmd/config.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 9c66329e96e..c0616dcd2fd 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -733,6 +733,7 @@ port_infos_display(portid_t port_id) > printf("Max segment number per MTU/TSO: %hu\n", > dev_info.tx_desc_lim.nb_mtu_seg_max); > > + printf("Device capabilities: 0x%"PRIx64"\n", dev_info.dev_capa); IMHO, it should be decoded > /* Show switch info only if valid switch domain and port id is set */ > if (dev_info.switch_info.domain_id != > RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID) { > @@ -743,6 +744,9 @@ port_infos_display(portid_t port_id) > dev_info.switch_info.domain_id); > printf("Switch Port Id: %u\n", > dev_info.switch_info.port_id); > + if ((dev_info.dev_capa & RTE_ETH_DEV_CAPA_RXQ_SHARE) != 0) > + printf("Switch Rx domain: %u\n", > + dev_info.switch_info.rx_domain); > } > } > >