From: Eric Blake <firstname.lastname@example.org> To: Max Reitz <email@example.com>, firstname.lastname@example.org Cc: Vladimir Sementsov-Ogievskiy <email@example.com>, Juan Quintela <firstname.lastname@example.org>, Markus Armbruster <email@example.com>, firstname.lastname@example.org, Peter Krempa <email@example.com>, "Dr . David Alan Gilbert" <firstname.lastname@example.org> Subject: Re: [RFC] migration: Add migrate-set-bitmap-node-mapping Date: Wed, 13 May 2020 11:01:14 -0500 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 5/13/20 9:49 AM, Max Reitz wrote: > This command allows mapping block node names to aliases for the purpose > of block dirty bitmap migration. > > This way, management tools can use different node names on the source > and destination and pass the mapping of how bitmaps are to be > transferred to qemu (on the source, the destination, or even both with > arbitrary aliases in the migration stream). > > Suggested-by: Vladimir Sementsov-Ogievskiy <email@example.com> > Signed-off-by: Max Reitz <firstname.lastname@example.org> > --- > Branch: https://github.com/XanClic/qemu.git migration-bitmap-mapping-rfc > Branch: https://git.xanclic.moe/XanClic/qemu.git migration-bitmap-mapping-rfc > > Vladimir has proposed something like this in April: > https://lists.nongnu.org/archive/html/qemu-block/2020-04/msg00171.html > > Now I’ve been asked by my manager to look at this, so I decided to just > write a patch to see how it’d play out. > > This is an RFC, because I’d like to tack on tests to the final version, > but I’m not sure whether I can come up with something before the end of > the week (and I’ll be on PTO for the next two weeks). > > Also, I don’t know whether migration/block-dirty-bitmap.c is the best > place to put qmp_migrate_set_bitmap_mapping(), but it appears we already > have some QMP handlers in migration/, so I suppose it isn’t too bad. My 'qemu-img bitmap' series has block/monitor/bitmap-qmp-cmds.c - perhaps that's a decent location? Or maybe another new file in that directory, if putting it directly in an existing file would drag in too much into qemu-img? > --- > qapi/migration.json | 36 ++++++++++++++++++++ > migration/block-dirty-bitmap.c | 60 ++++++++++++++++++++++++++++++++-- > 2 files changed, 94 insertions(+), 2 deletions(-) But I see you've already posted a v2, so I'll stop reviewing here and switch to that thread. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-05-13 16:06 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-13 14:49 Max Reitz 2020-05-13 14:51 ` Max Reitz 2020-05-13 16:01 ` Eric Blake [this message] 2020-05-13 19:34 ` no-reply 2020-05-13 19:37 ` no-reply 2020-05-13 19:40 ` no-reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [RFC] migration: Add migrate-set-bitmap-node-mapping' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.