From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShKze-0006aP-0b for qemu-devel@nongnu.org; Wed, 20 Jun 2012 09:30:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShKzX-0005Gu-4b for qemu-devel@nongnu.org; Wed, 20 Jun 2012 09:30:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShKzW-0005GM-TI for qemu-devel@nongnu.org; Wed, 20 Jun 2012 09:30:39 -0400 From: Igor Mammedov Date: Wed, 20 Jun 2012 14:59:22 +0200 Message-Id: <1340197164-9574-4-git-send-email-imammedo@redhat.com> In-Reply-To: <1340197164-9574-1-git-send-email-imammedo@redhat.com> References: <1340197164-9574-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH 3/5] target-i386: call x86_cpu_realize() after APIC is initialized. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, afaerber@suse.de It's not correct to make CPU runnable (i.e. calling x86_cpu_realize()) when not all properties are set (APIC in this case). Fix it by calling x86_cpu_realize() at board level after APIC is initialized, right before cpu_reset(). Signed-off-by: Igor Mammedov --- hw/pc.c | 1 + target-i386/helper.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 8368701..8a662cf 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -948,6 +948,7 @@ static X86CPU *pc_new_cpu(const char *cpu_model) env->apic_state = apic_init(env, env->cpuid_apic_id); } qemu_register_reset(pc_cpu_reset, cpu); + x86_cpu_realize(OBJECT(cpu), NULL); pc_cpu_reset(cpu); return cpu; } diff --git a/target-i386/helper.c b/target-i386/helper.c index c52ec13..b38ea7f 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -1161,8 +1161,6 @@ X86CPU *cpu_x86_init(const char *cpu_model) return NULL; } - x86_cpu_realize(OBJECT(cpu), NULL); - return cpu; } -- 1.7.10.2