From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [RFC PATCH 11/17] PowerPC: booke64: Fix machine check handler to use the right prolog Date: Wed, 27 Jun 2012 08:13:38 +1000 Message-ID: <1340748818.3732.30.camel@pasglop> References: <1340627195-11544-1-git-send-email-mihai.caraman@freescale.com> <1340627195-11544-12-git-send-email-mihai.caraman@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, qemu-ppc@nongnu.org To: Mihai Caraman Return-path: In-Reply-To: <1340627195-11544-12-git-send-email-mihai.caraman@freescale.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, 2012-06-25 at 15:26 +0300, Mihai Caraman wrote: > Machine check exception handler was using a wrong prolog. Hypervisors, like > KVM, which are called early from the exception handler rely on the interrupt > source. > > Signed-off-by: Mihai Caraman Ack. Please separate your "core" patches from your KVM series and submit them separately. I'll take care of the core Book3E part. Cheers, Ben. > --- > arch/powerpc/kernel/exceptions-64e.S | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/exceptions-64e.S > index 52aa96b..06f7aec 100644 > --- a/arch/powerpc/kernel/exceptions-64e.S > +++ b/arch/powerpc/kernel/exceptions-64e.S > @@ -290,7 +290,7 @@ interrupt_end_book3e: > > /* Machine Check Interrupt */ > START_EXCEPTION(machine_check); > - CRIT_EXCEPTION_PROLOG(0x200, PROLOG_ADDITION_NONE) > + MC_EXCEPTION_PROLOG(0x200, PROLOG_ADDITION_NONE) > // EXCEPTION_COMMON(0x200, PACA_EXMC, INTS_DISABLE) > // bl special_reg_save_mc > // addi r3,r1,STACK_FRAME_OVERHEAD From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id ABA35100B95 for ; Wed, 27 Jun 2012 08:13:56 +1000 (EST) Message-ID: <1340748818.3732.30.camel@pasglop> Subject: Re: [RFC PATCH 11/17] PowerPC: booke64: Fix machine check handler to use the right prolog From: Benjamin Herrenschmidt To: Mihai Caraman Date: Wed, 27 Jun 2012 08:13:38 +1000 In-Reply-To: <1340627195-11544-12-git-send-email-mihai.caraman@freescale.com> References: <1340627195-11544-1-git-send-email-mihai.caraman@freescale.com> <1340627195-11544-12-git-send-email-mihai.caraman@freescale.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: qemu-ppc@nongnu.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2012-06-25 at 15:26 +0300, Mihai Caraman wrote: > Machine check exception handler was using a wrong prolog. Hypervisors, like > KVM, which are called early from the exception handler rely on the interrupt > source. > > Signed-off-by: Mihai Caraman Ack. Please separate your "core" patches from your KVM series and submit them separately. I'll take care of the core Book3E part. Cheers, Ben. > --- > arch/powerpc/kernel/exceptions-64e.S | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/exceptions-64e.S > index 52aa96b..06f7aec 100644 > --- a/arch/powerpc/kernel/exceptions-64e.S > +++ b/arch/powerpc/kernel/exceptions-64e.S > @@ -290,7 +290,7 @@ interrupt_end_book3e: > > /* Machine Check Interrupt */ > START_EXCEPTION(machine_check); > - CRIT_EXCEPTION_PROLOG(0x200, PROLOG_ADDITION_NONE) > + MC_EXCEPTION_PROLOG(0x200, PROLOG_ADDITION_NONE) > // EXCEPTION_COMMON(0x200, PACA_EXMC, INTS_DISABLE) > // bl special_reg_save_mc > // addi r3,r1,STACK_FRAME_OVERHEAD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Date: Tue, 26 Jun 2012 22:13:38 +0000 Subject: Re: [RFC PATCH 11/17] PowerPC: booke64: Fix machine check handler to use the right prolog Message-Id: <1340748818.3732.30.camel@pasglop> List-Id: References: <1340627195-11544-1-git-send-email-mihai.caraman@freescale.com> <1340627195-11544-12-git-send-email-mihai.caraman@freescale.com> In-Reply-To: <1340627195-11544-12-git-send-email-mihai.caraman@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mihai Caraman Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, qemu-ppc@nongnu.org On Mon, 2012-06-25 at 15:26 +0300, Mihai Caraman wrote: > Machine check exception handler was using a wrong prolog. Hypervisors, like > KVM, which are called early from the exception handler rely on the interrupt > source. > > Signed-off-by: Mihai Caraman Ack. Please separate your "core" patches from your KVM series and submit them separately. I'll take care of the core Book3E part. Cheers, Ben. > --- > arch/powerpc/kernel/exceptions-64e.S | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/exceptions-64e.S > index 52aa96b..06f7aec 100644 > --- a/arch/powerpc/kernel/exceptions-64e.S > +++ b/arch/powerpc/kernel/exceptions-64e.S > @@ -290,7 +290,7 @@ interrupt_end_book3e: > > /* Machine Check Interrupt */ > START_EXCEPTION(machine_check); > - CRIT_EXCEPTION_PROLOG(0x200, PROLOG_ADDITION_NONE) > + MC_EXCEPTION_PROLOG(0x200, PROLOG_ADDITION_NONE) > // EXCEPTION_COMMON(0x200, PACA_EXMC, INTS_DISABLE) > // bl special_reg_save_mc > // addi r3,r1,STACK_FRAME_OVERHEAD