All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 06/17] Bluetooth: Add Three-wire header value convenience macros
Date: Wed, 27 Jun 2012 14:25:56 +0300	[thread overview]
Message-ID: <1340796367-10321-7-git-send-email-johan.hedberg@gmail.com> (raw)
In-Reply-To: <1340796367-10321-1-git-send-email-johan.hedberg@gmail.com>

From: Johan Hedberg <johan.hedberg@intel.com>

This patch adds convenience macros for reading Three-wire header values.
This will help make the code more readable.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---
 drivers/bluetooth/hci_h5.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
index 6b02ccc..0d608f3 100644
--- a/drivers/bluetooth/hci_h5.c
+++ b/drivers/bluetooth/hci_h5.c
@@ -41,6 +41,14 @@
  */
 #define H5_MAX_LEN (4 + 0xfff + 2)
 
+/* Convenience macros for reading Three-wire header values */
+#define H5_HDR_SEQ(hdr)		((hdr)[0] & 0x07)
+#define H5_HDR_ACK(hdr)		(((hdr)[0] >> 3) & 0x07)
+#define H5_HDR_CRC(hdr)		(((hdr)[0] >> 6) & 0x01)
+#define H5_HDR_RELIABLE(hdr)	(((hdr)[0] >> 7) & 0x01)
+#define H5_HDR_PKT_TYPE(hdr)	((hdr)[1] & 0x0f)
+#define H5_HDR_LEN(hdr)		((((hdr)[1] >> 4) & 0xff) + ((hdr)[2] << 4))
+
 #define SLIP_DELIMITER	0xc0
 #define SLIP_ESC	0xdb
 #define SLIP_ESC_DELIM	0xdc
-- 
1.7.10.4


  parent reply	other threads:[~2012-06-27 11:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-27 11:25 [PATCH 00/17] Bluetooth: Implement Three-wire UART HCI driver Johan Hedberg
2012-06-27 11:25 ` [PATCH 01/17] Bluetooth: Initial skeleton for Three-wire UART (H5) support Johan Hedberg
2012-06-27 11:25 ` [PATCH 02/17] Bluetooth: Add basic state tracking to Three-wire UART driver Johan Hedberg
2012-06-27 11:25 ` [PATCH 03/17] Bluetooth: Add initial reliable packet support for Three-wire UART Johan Hedberg
2012-07-09 14:34   ` Gustavo Padovan
2012-06-27 11:25 ` [PATCH 04/17] Bluetooth: Add basic packet parsing to Three-wire UART driver Johan Hedberg
2012-07-09 14:44   ` Gustavo Padovan
2012-06-27 11:25 ` [PATCH 05/17] Bluetooth: Add initial packet sending support to Three-wire UART Johan Hedberg
2012-06-27 11:25 ` Johan Hedberg [this message]
2012-06-27 11:25 ` [PATCH 07/17] Bluetooth: Fix/implement Three-wire reliable packet sending Johan Hedberg
2012-06-27 11:25 ` [PATCH 08/17] Bluetooth: Add support for Three-wire Link Control packets Johan Hedberg
2012-07-10 18:51   ` Gustavo Padovan
2012-06-27 11:25 ` [PATCH 09/17] Bluetooth: Simplify hci_uart_tty_close logic Johan Hedberg
2012-06-27 11:26 ` [PATCH 10/17] Bluetooth: Add delayed init sequence support for UART controllers Johan Hedberg
2012-07-10 18:53   ` Gustavo Padovan
2012-06-27 11:26 ` [PATCH 11/17] Bluetooth: Use delayed init for Three-wire UART Johan Hedberg
2012-06-27 11:26 ` [PATCH 12/17] Bluetooth: Improve rx debug logs " Johan Hedberg
2012-06-27 11:26 ` [PATCH 13/17] Bluetooth: Add initial sleep support to " Johan Hedberg
2012-07-10 18:57   ` Gustavo Padovan
2012-06-27 11:26 ` [PATCH 14/17] Bluetooth: Add initialization tracking to HCI Three-wire driver Johan Hedberg
2012-07-10 18:58   ` Gustavo Padovan
2012-06-27 11:26 ` [PATCH 15/17] Bluetooth: Implement proper low-power support for Three-wire UART Johan Hedberg
2012-06-27 11:26 ` [PATCH 16/17] Bluetooth: Remove unnecessary h5_build_pkt function Johan Hedberg
2012-06-27 11:26 ` [PATCH 17/17] Bluetooth: Improve Three-wire UART configuration handling Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340796367-10321-7-git-send-email-johan.hedberg@gmail.com \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.