From: Joerg Rebenstorf <Joerg.Rebenstorf@GiN.de>
To: buildroot@busybox.net
Subject: [Buildroot] Avahi build failed with BR2_STRIP_none=y and BR2_ENABLE_DEBUG=n
Date: Wed, 27 Jun 2012 14:41:27 +0200 [thread overview]
Message-ID: <1340800887.3122.113.camel@jr-ThinkCentre-A57> (raw)
Hello,
I just want to let the community know that I've found a bug and fixed it
in buildroot-2009.11.
Bugfix: Fix avahi build breakage with BR2_STRIP_none=y and
BR2_ENABLE_DEBUG=n
The fix works like this:
Look at BR2_STRIP_none to decide whether to strip avahi binaries.
This avoids bad quoting in avahi Makefile.in when $STRIP is set to:
true Not_stripping
Index: /usr/cross/GL4200/buildroot-2009.11/package/avahi/avahi.mk
===================================================================
--- /usr/cross/GL4200/buildroot-2009.11/package/avahi/avahi.mk (revision
7)
+++ /usr/cross/GL4200/buildroot-2009.11/package/avahi/avahi.mk (working
copy)
@@ -16,6 +16,12 @@
AVAHI_INSTALL_STAGING = YES
AVAHI_INSTALL_TARGET = YES
+ifeq ($(BR2_STRIP_none),y)
+AVAHI_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install-exec
+else
+AVAHI_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install-strip
+endif
+
AVAHI_CONF_ENV = ac_cv_func_strtod=yes \
ac_fsusage_space=yes \
fu_cv_sys_stat_statfs2_bsize=yes \
Without this fix you get the following output:
>>> libdaemon 0.13 Installing to target
/usr/bin/make -j8
DESTDIR=/usr/cross/GL4200/buildroot-2009.11/output/target install-strip
-C /usr/cross/GL4200/buildroot-2009.11/output/build/libdaemon-0.13/
make[1]: Entering directory
`/usr/cross/GL4200/buildroot-2009.11/output/build/libdaemon-0.13'
/usr/bin/make
INSTALL_PROGRAM="/bin/bash /usr/cross/GL4200/buildroot-2009.11/output/build/libdaemon-0.13/install-sh -c -s" \
install_sh_PROGRAM="/bin/bash /usr/cross/GL4200/buildroot-2009.11/output/build/libdaemon-0.13/install-sh -c -s" INSTALL_STRIP_FLAG=-s \
`test -z 'true Not_stripping' || \
echo "INSTALL_PROGRAM_ENV=STRIPPROG='true Not_stripping'"` install
make[2]: *** make[2]: Entering directory
`/usr/cross/GL4200/buildroot-2009.11/output/build/libdaemon-0.13'
No rule to make target `Not_stripping''. Stop.
make[2]: Leaving directory
`/usr/cross/GL4200/buildroot-2009.11/output/build/libdaemon-0.13'
make[1]: *** [install-strip] Error 2
make[1]: Leaving directory
`/usr/cross/GL4200/buildroot-2009.11/output/build/libdaemon-0.13'
make: ***
[/usr/cross/GL4200/buildroot-2009.11/output/build/libdaemon-0.13/.stamp_target_installed] Error 2
Any comments are welcome.
Cheers,
J?rg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120627/e8ae1e5c/attachment.asc>
next reply other threads:[~2012-06-27 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 12:41 Joerg Rebenstorf [this message]
2012-06-27 14:29 ` [Buildroot] Avahi build failed with BR2_STRIP_none=y and BR2_ENABLE_DEBUG=n Joerg Rebenstorf
2012-06-27 14:35 ` Thomas Petazzoni
2012-06-27 14:29 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340800887.3122.113.camel@jr-ThinkCentre-A57 \
--to=joerg.rebenstorf@gin.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.