* [PATCH] net: Downgrade CAP_SYS_MODULE deprecated message from error to warning.
@ 2012-06-28 0:32 Vinson Lee
2012-06-28 23:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Vinson Lee @ 2012-06-28 0:32 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, mirq-linux, Jiri Pirko, Tom Herbert
Cc: netdev, linux-kernel, Vinson Lee, David Mackey
Make logging level consistent with other deprecation messages in net
subsystem.
Signed-off-by: Vinson Lee <vlee@twitter.com>
Cc: David Mackey <tdmackey@twitter.com>
---
| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--git a/net/core/dev.c b/net/core/dev.c
index cd09819..b19a361 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1136,8 +1136,8 @@ void dev_load(struct net *net, const char *name)
no_module = request_module("netdev-%s", name);
if (no_module && capable(CAP_SYS_MODULE)) {
if (!request_module("%s", name))
- pr_err("Loading kernel module for a network device with CAP_SYS_MODULE (deprecated). Use CAP_NET_ADMIN and alias netdev-%s instead.\n",
- name);
+ pr_warn("Loading kernel module for a network device with CAP_SYS_MODULE (deprecated). Use CAP_NET_ADMIN and alias netdev-%s instead.\n",
+ name);
}
}
EXPORT_SYMBOL(dev_load);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: Downgrade CAP_SYS_MODULE deprecated message from error to warning.
2012-06-28 0:32 [PATCH] net: Downgrade CAP_SYS_MODULE deprecated message from error to warning Vinson Lee
@ 2012-06-28 23:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-06-28 23:55 UTC (permalink / raw)
To: vlee
Cc: edumazet, mirq-linux, jpirko, therbert, netdev, linux-kernel, tdmackey
From: Vinson Lee <vlee@twitter.com>
Date: Wed, 27 Jun 2012 17:32:07 -0700
> Make logging level consistent with other deprecation messages in net
> subsystem.
>
> Signed-off-by: Vinson Lee <vlee@twitter.com>
> Cc: David Mackey <tdmackey@twitter.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-28 23:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-28 0:32 [PATCH] net: Downgrade CAP_SYS_MODULE deprecated message from error to warning Vinson Lee
2012-06-28 23:55 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.