From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42422)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1SlUks-0000CS-Fv
	for qemu-devel@nongnu.org; Sun, 01 Jul 2012 20:44:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1SlUkq-00083j-S6
	for qemu-devel@nongnu.org; Sun, 01 Jul 2012 20:44:42 -0400
Received: from gate.crashing.org ([63.228.1.57]:55412)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1SlUkq-00083W-JD
	for qemu-devel@nongnu.org; Sun, 01 Jul 2012 20:44:40 -0400
Message-ID: <1341189871.2588.11.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Mon, 02 Jul 2012 10:44:31 +1000
In-Reply-To: <4FF0E5FB.1080200@ozlabs.ru>
References: <4FF02F2C.30006@ozlabs.ru> <20120701124314.GB4782@redhat.com>
	<4FF04939.7050608@ozlabs.ru> <1341184071.2588.10.camel@pasglop>
	<4FF0E5FB.1080200@ozlabs.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Subject: Re: [Qemu-devel] QEMU question: is eventfd not thread safe?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Alex Williamson <alex.williamson@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On Mon, 2012-07-02 at 10:06 +1000, Alexey Kardashevskiy wrote:
> > Won't that conflict with the business in coroutine-sigaltstack.c ?
> 
> The code which touches SIGUSR2 does not compile on power.

Oh, we don't get the altstack coroutine stuff ? interesting...

> > Hrm... looking at it, it looks like it will save/restore the handler,
> > so that should be good.
> >  
> > Still, one might want to wrap that into something, like
> > qemu_wake_main_loop();
> 
> 
> I already posted another patch with qemu_notify_event() in this mail thread later :)

Ok. Thanks.

Cheers,
Ben.

> 
> > 
> > Cheers,
> > Ben.
> > 
> >>>>  int main_loop_init(void)
> >>>>  {
> >>>>      int ret;
> >>>>  
> >>>> +    sigusr2_init();
> >>>> +
> >>>>      qemu_mutex_lock_iothread();
> >>>>      ret = qemu_signal_init();
> >>>>      if (ret) {
> >>>> -- 
> >>>> 1.7.10
> >>
> >>
> > 
> > 
> 
>