All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: wireless <linux-wireless@vger.kernel.org>
Subject: Re: Kernel oops in __netif_schedule() for at76c50x-usb
Date: Mon, 02 Jul 2012 17:31:27 +0200	[thread overview]
Message-ID: <1341243087.19642.20.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4FF1BC71.4070002@lwfinger.net> (sfid-20120702_172127_238924_ED185EFD)

Hi Larry,

Sorry! I had your other email still marked unread but hadn't gotten
around to it :-(

> Regarding the oops that I reported for PPC architecture that reported "Unable to 
> handle kernel paging request for data at address 0x000004c", I have now repeated 
> it on x86_64 architecture, where the objdump tool is better. The error occurs in 
> the line in __netif_schedule() that says
> 
>           if (!test_and_set_bit(__QDISC_STATE_SCHED, &q->state))
> 
> Debug printouts have shown that q is not NULL, and it appears to be in the 
> correct address range. I think q->state is zero; however, q->state cannot be 
> written.
> 
> Additional testing shows this problem to be another side effect of commit 
> 3a25a8c ("mac80211: add improved HW queue control") for a device with only a 
> single HW queue.

Looking at the code again, it seems pretty obviously wrong ... OUCH!

I'm not sure which fix is correct though. Should we have software QoS
queues for these drivers, but we'll never use them? Then this would
work:
http://p.sipsolutions.net/e015bf7db9a05887.txt

Or we could change the enable code path. Hmm.

johannes


  reply	other threads:[~2012-07-02 15:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02 15:21 Kernel oops in __netif_schedule() for at76c50x-usb Larry Finger
2012-07-02 15:31 ` Johannes Berg [this message]
2012-07-02 16:12   ` Larry Finger
2012-07-02 17:38     ` Johannes Berg
2012-07-02 22:50       ` Larry Finger
2012-07-04  9:46         ` Johannes Berg
2012-07-04 10:49           ` Johannes Berg
2012-07-04 10:54             ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341243087.19642.20.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.