All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stuart Yoder <stuart.yoder@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org, agraf@suse.de
Subject: Re: [PATCH][v3] PPC: use CURRENT_THREAD_INFO instead of open coded assembly
Date: Wed, 04 Jul 2012 13:04:57 +1000	[thread overview]
Message-ID: <1341371097.2346.15.camel@pasglop> (raw)
In-Reply-To: <1341328312-17102-1-git-send-email-stuart.yoder@freescale.com>

On Tue, 2012-07-03 at 10:11 -0500, Stuart Yoder wrote:
> From: Stuart Yoder <stuart.yoder@freescale.com>
> 
> Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
> ---
> 
> -v3
>    -moved CURRENT_THREAD_INFO out from under the assembly only
>     #define as per comments on mailing list
>    -reversed logic of 64-bit #ifdef for CURRENT_THREAD_INFO 
>     macro

Almost there :-)

>  #define RUNLATCH_ON				\
>  BEGIN_FTR_SECTION				\
> -	clrrdi	r3,r1,THREAD_SHIFT;		\
> +	CURRENT_THREAD_INFO(r3, r1)		\

Missing semicolon (in a macro you need it)

>  	ld	r4,TI_LOCAL_FLAGS(r3);		\
>  	andi.	r0,r4,_TLF_RUNLATCH;		\
>  	beql	ppc64_runlatch_on_trampoline;	\
> @@ -332,7 +332,7 @@ label##_common:							\
>  #ifdef CONFIG_PPC_970_NAP
>  #define FINISH_NAP				\
>  BEGIN_FTR_SECTION				\
> -	clrrdi	r11,r1,THREAD_SHIFT;		\
> +	CURRENT_THREAD_INFO(r11, r1)		\

Same

> --- a/arch/powerpc/kernel/exceptions-64e.S
> +++ b/arch/powerpc/kernel/exceptions-64e.S
> @@ -222,7 +222,7 @@ exc_##n##_bad_stack:							    \
>   * interrupts happen before the wait instruction.
>   */
>  #define CHECK_NAPPING()							\
> -	clrrdi	r11,r1,THREAD_SHIFT;					\
> +	CURRENT_THREAD_INFO(r11, r1)

Missing both semicolon and backslash

Cheers,
Ben.

      reply	other threads:[~2012-07-04  3:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 15:11 [PATCH][v3] PPC: use CURRENT_THREAD_INFO instead of open coded assembly Stuart Yoder
2012-07-04  3:04 ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341371097.2346.15.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=agraf@suse.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=stuart.yoder@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.