From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmTEy-000054-8F for qemu-devel@nongnu.org; Wed, 04 Jul 2012 13:19:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmTEw-0004VG-5g for qemu-devel@nongnu.org; Wed, 04 Jul 2012 13:19:47 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Wed, 4 Jul 2012 19:19:24 +0200 Message-Id: <1341422373-13614-6-git-send-email-afaerber@suse.de> In-Reply-To: <1341422373-13614-1-git-send-email-afaerber@suse.de> References: <1341422373-13614-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v3 05/14] grackle_pci: QOM'ify Grackle PCI host bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mst@redhat.com, jbaron@redhat.com, Alexander Graf , "open list:Old World" , anthony@codemonkey.ws, pbonzini@redhat.com, =?UTF-8?q?Andreas=20F=C3=A4rber?= Introduce type constant. Introduce cast macro to drop dummy busdev field used with FROM_SYSBUS() that would've broken SYS_BUS_DEVICE(). Avoid accessing parent fields directly. Drop no-op reset function. Signed-off-by: Andreas F=C3=A4rber --- hw/grackle_pci.c | 57 ++++++++++++++++++++++++++----------------------= ----- hw/ppc_mac.h | 1 + 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/hw/grackle_pci.c b/hw/grackle_pci.c index 35667ad..d814270 100644 --- a/hw/grackle_pci.c +++ b/hw/grackle_pci.c @@ -23,10 +23,9 @@ * THE SOFTWARE. */ =20 -#include "sysbus.h" +#include "pci_host.h" #include "ppc_mac.h" #include "pci.h" -#include "pci_host.h" =20 /* debug Grackle */ //#define DEBUG_GRACKLE @@ -38,9 +37,12 @@ #define GRACKLE_DPRINTF(fmt, ...) #endif =20 +#define GRACKLE_PCI_HOST_BRIDGE(obj) \ + OBJECT_CHECK(GrackleState, (obj), TYPE_GRACKLE_PCI_HOST_BRIDGE) + typedef struct GrackleState { - SysBusDevice busdev; PCIHostState host_state; + MemoryRegion pci_mmio; MemoryRegion pci_hole; } GrackleState; @@ -59,22 +61,20 @@ static void pci_grackle_set_irq(void *opaque, int irq= _num, int level) qemu_set_irq(pic[irq_num + 0x15], level); } =20 -static void pci_grackle_reset(void *opaque) -{ -} - PCIBus *pci_grackle_init(uint32_t base, qemu_irq *pic, MemoryRegion *address_space_mem, MemoryRegion *address_space_io) { DeviceState *dev; SysBusDevice *s; + PCIHostState *phb; GrackleState *d; =20 - dev =3D qdev_create(NULL, "grackle-pcihost"); + dev =3D qdev_create(NULL, TYPE_GRACKLE_PCI_HOST_BRIDGE); qdev_init_nofail(dev); - s =3D sysbus_from_qdev(dev); - d =3D FROM_SYSBUS(GrackleState, s); + s =3D SYS_BUS_DEVICE(dev); + phb =3D FROM_SYSBUS(PCIHostState, s); + d =3D GRACKLE_PCI_HOST_BRIDGE(dev); =20 memory_region_init(&d->pci_mmio, "pci-mmio", 0x100000000ULL); memory_region_init_alias(&d->pci_hole, "pci-hole", &d->pci_mmio, @@ -82,36 +82,35 @@ PCIBus *pci_grackle_init(uint32_t base, qemu_irq *pic= , memory_region_add_subregion(address_space_mem, 0x80000000ULL, &d->pci_hole); =20 - d->host_state.bus =3D pci_register_bus(&d->busdev.qdev, "pci", - pci_grackle_set_irq, - pci_grackle_map_irq, - pic, - &d->pci_mmio, - address_space_io, - 0, 4); + phb->bus =3D pci_register_bus(dev, "pci", + pci_grackle_set_irq, + pci_grackle_map_irq, + pic, + &d->pci_mmio, + address_space_io, + 0, 4); =20 - pci_create_simple(d->host_state.bus, 0, "grackle"); + pci_create_simple(phb->bus, 0, "grackle"); =20 sysbus_mmio_map(s, 0, base); sysbus_mmio_map(s, 1, base + 0x00200000); =20 - return d->host_state.bus; + return phb->bus; } =20 static int pci_grackle_init_device(SysBusDevice *dev) { - GrackleState *s; + PCIHostState *phb; =20 - s =3D FROM_SYSBUS(GrackleState, dev); + phb =3D FROM_SYSBUS(PCIHostState, dev); =20 - memory_region_init_io(&s->host_state.conf_mem, &pci_host_conf_le_ops= , - &s->host_state, "pci-conf-idx", 0x1000); - memory_region_init_io(&s->host_state.data_mem, &pci_host_data_le_ops= , - &s->host_state, "pci-data-idx", 0x1000); - sysbus_init_mmio(dev, &s->host_state.conf_mem); - sysbus_init_mmio(dev, &s->host_state.data_mem); + memory_region_init_io(&phb->conf_mem, &pci_host_conf_le_ops, + dev, "pci-conf-idx", 0x1000); + memory_region_init_io(&phb->data_mem, &pci_host_data_le_ops, + dev, "pci-data-idx", 0x1000); + sysbus_init_mmio(dev, &phb->conf_mem); + sysbus_init_mmio(dev, &phb->data_mem); =20 - qemu_register_reset(pci_grackle_reset, &s->host_state); return 0; } =20 @@ -151,7 +150,7 @@ static void pci_grackle_class_init(ObjectClass *klass= , void *data) } =20 static const TypeInfo grackle_pci_host_info =3D { - .name =3D "grackle-pcihost", + .name =3D TYPE_GRACKLE_PCI_HOST_BRIDGE, .parent =3D TYPE_SYS_BUS_DEVICE, .instance_size =3D sizeof(GrackleState), .class_init =3D pci_grackle_class_init, diff --git a/hw/ppc_mac.h b/hw/ppc_mac.h index af75e45..7d08418 100644 --- a/hw/ppc_mac.h +++ b/hw/ppc_mac.h @@ -55,6 +55,7 @@ qemu_irq *heathrow_pic_init(MemoryRegion **pmem, int nb_cpus, qemu_irq **irqs); =20 /* Grackle PCI */ +#define TYPE_GRACKLE_PCI_HOST_BRIDGE "grackle-pcihost" PCIBus *pci_grackle_init(uint32_t base, qemu_irq *pic, MemoryRegion *address_space_mem, MemoryRegion *address_space_io); --=20 1.7.7