From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: linux-mm@kvack.org
Cc: dave@linux.vnet.ibm.com, mhocko@suse.cz, rientjes@google.com,
akpm@linux-foundation.org, Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: [PATCH 3/3] mm/sparse: remove index_init_lock
Date: Fri, 6 Jul 2012 11:09:38 +0800 [thread overview]
Message-ID: <1341544178-7245-3-git-send-email-shangw@linux.vnet.ibm.com> (raw)
In-Reply-To: <1341544178-7245-1-git-send-email-shangw@linux.vnet.ibm.com>
Apart from call to sparse_index_init() during boot stage, the function
is mainly used for hotplug case as follows and protected by hotplug
mutex "mem_hotplug_mutex". So we needn't the spinlock in sparse_index_init().
sparse_index_init
sparse_add_one_section
__add_section
__add_pages
arch_add_memory
add_memory
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
---
mm/sparse.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/mm/sparse.c b/mm/sparse.c
index 8b8edfb..4437c6c 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -77,7 +77,6 @@ static struct mem_section noinline __init_refok *sparse_index_alloc(int nid)
static int __meminit sparse_index_init(unsigned long section_nr, int nid)
{
- static DEFINE_SPINLOCK(index_init_lock);
unsigned long root = SECTION_NR_TO_ROOT(section_nr);
struct mem_section *section;
int ret = 0;
@@ -88,20 +87,9 @@ static int __meminit sparse_index_init(unsigned long section_nr, int nid)
section = sparse_index_alloc(nid);
if (!section)
return -ENOMEM;
- /*
- * This lock keeps two different sections from
- * reallocating for the same index
- */
- spin_lock(&index_init_lock);
-
- if (mem_section[root]) {
- ret = -EEXIST;
- goto out;
- }
mem_section[root] = section;
-out:
- spin_unlock(&index_init_lock);
+
return ret;
}
#else /* !SPARSEMEM_EXTREME */
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-06 3:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 3:09 [PATCH v4 1/3] mm/sparse: optimize sparse_index_alloc Gavin Shan
2012-07-06 3:09 ` [PATCH v4 2/3] mm/sparse: more check on mem_section number Gavin Shan
2012-07-06 3:09 ` Gavin Shan [this message]
2012-07-09 11:13 ` [PATCH 3/3] mm/sparse: remove index_init_lock Michal Hocko
2012-07-09 11:59 ` Gavin Shan
2012-07-10 15:59 ` Michal Hocko
2012-07-12 5:48 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341544178-7245-3-git-send-email-shangw@linux.vnet.ibm.com \
--to=shangw@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.