Re: [PATCH 00 of 10 v3] Automatic NUMA placement for xl

From: Ian Campbell <Ian.Campbell@citrix.com>
To: Dario Faggioli <raistlin@linux.it>
Cc: Andre Przywara <andre.przywara@amd.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Juergen Gross <juergen.gross@ts.fujitsu.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 00 of 10 v3] Automatic NUMA placement for xl
Date: Fri, 6 Jul 2012 12:20:38 +0100	[thread overview]
Message-ID: <1341573638.32747.29.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <1341573377.32747.27.camel@zakaz.uk.xensource.com>

On Fri, 2012-07-06 at 12:16 +0100, Ian Campbell wrote:
> There are a few "goto out"s before initialising that variable, but none
> of them log (really they should) and I didn't investigate which one it
> was yet.

It seems to be:
   /* If we don't have at least 2 nodes, it is useless to proceed */
    if (nr_nodes < 2) {
        LOG(DEBUG, "only %d node. no placement required", nr_nodes);
        rc = 0;
        goto out;
    }

(LOG is mine...). The other exit paths look like the log further down
the stack but not this one so it is worth adding.

You probably want another libxl_bitmap_init near the top of the
function.

Ian.