All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Mason <jdmason@kudzu.us>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH 09/11] sungem: remove unnecessary setting of skb->dev
Date: Mon,  9 Jul 2012 17:09:33 -0700	[thread overview]
Message-ID: <1341878975-10577-9-git-send-email-jdmason@kudzu.us> (raw)
In-Reply-To: <1341878975-10577-1-git-send-email-jdmason@kudzu.us>

skb->dev is being unnecessarily set by the driver's skb alloc routine (which is
called in init and during rx).  It is already being set to the proper value when
eth_type_trans is called on packet receive, and the skb->dev is not referenced
anywhere else in the code.

Signed-off-by: Jon Mason <jdmason@kudzu.us>
---
 drivers/net/ethernet/sun/sungem.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c
index 3cf4ab7..9ae12d0 100644
--- a/drivers/net/ethernet/sun/sungem.c
+++ b/drivers/net/ethernet/sun/sungem.c
@@ -752,7 +752,6 @@ static __inline__ struct sk_buff *gem_alloc_skb(struct net_device *dev, int size
 	if (likely(skb)) {
 		unsigned long offset = ALIGNED_RX_SKB_ADDR(skb->data);
 		skb_reserve(skb, offset);
-		skb->dev = dev;
 	}
 	return skb;
 }
-- 
1.7.9.5

  parent reply	other threads:[~2012-07-10  0:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10  0:09 [PATCH 01/11] lance: remove unnecessary setting of skb->dev Jon Mason
2012-07-10  0:09 ` [PATCH 02/11] enic: " Jon Mason
2012-07-12 21:19   ` Jon Mason
2012-07-12 21:23     ` Christian Benvenuti (benve)
2012-07-13  4:56       ` Neel Patel (neepatel)
2012-07-10  0:09 ` [PATCH 03/11] netxen: " Jon Mason
2012-07-10  0:09 ` [PATCH 04/11] lantiq_etop: " Jon Mason
2012-07-10  0:09 ` [PATCH 05/11] ksz884x: " Jon Mason
2012-07-10  0:09 ` [PATCH 06/11] qlcnic: " Jon Mason
2012-07-10  0:09 ` [PATCH 07/11] qlge: " Jon Mason
2012-07-10  0:09 ` [PATCH 08/11] sunbmac: " Jon Mason
2012-07-10  0:09 ` Jon Mason [this message]
2012-07-10  0:09 ` [PATCH 10/11] sunhme: " Jon Mason
2012-07-10  0:09 ` [PATCH 11/11] ll_temac: " Jon Mason
2012-07-11  6:18 ` [PATCH 01/11] lance: " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341878975-10577-9-git-send-email-jdmason@kudzu.us \
    --to=jdmason@kudzu.us \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.