From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michel =?ISO-8859-1?Q?D=E4nzer?= <michel@daenzer.net>
Subject: Re: [PATCH 15/15] drm/radeon: implement ring saving on reset v2
Date: Tue, 10 Jul 2012 16:50:01 +0200
Message-ID: <1341931801.12576.413.camel@thor.local>
References: <1341924684-563-1-git-send-email-deathsimple@vodafone.de>
	<1341924684-563-15-git-send-email-deathsimple@vodafone.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51])
	by gabe.freedesktop.org (Postfix) with ESMTP id 926DFA0A81
	for <dri-devel@lists.freedesktop.org>;
	Tue, 10 Jul 2012 07:50:14 -0700 (PDT)
In-Reply-To: <1341924684-563-15-git-send-email-deathsimple@vodafone.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Christian =?ISO-8859-1?Q?K=F6nig?= <deathsimple@vodafone.de>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Die, 2012-07-10 at 14:51 +0200, Christian K=F6nig wrote: =

> Try to save whatever is on the rings when
> we encounter an lockup.
> =

> v2: Fix spelling error. Free saved ring data if reset fails.
>     Add documentation for the new functions.
> =

> Signed-off-by: Christian K=F6nig <deathsimple@vodafone.de>

Just some more spelling nits, otherwise this patch and patch 13 are

Reviewed-by: Michel D=E4nzer <michel.daenzer@amd.com>


> +/**
> + * radeon_ring_backup - Backup the content of a ring
> + *
> + * @rdev: radeon_device pointer
> + * @ring: the ring we want to backup

'back up', in both cases.

> + * Saves all unprocessed commits to a ring, returns the number of dwords=
 saved.
> + */

'unprocessed commands from'?


> +/**
> + * radeon_ring_restore - append saved commands to the ring again
> + *
> + * @rdev: radeon_device pointer
> + * @ring: ring to append commands to
> + * @size: number of dwords we want to write
> + * @data: saved commands
> + *
> + * Allocates space on the ring and restore the previusly saved commands.

'previously'


-- =

Earthling Michel D=E4nzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer