From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasilis Liaskovitis Subject: [RFC PATCH v2 05/21][SeaBIOS] pciinit: Fix pcimem_start value Date: Wed, 11 Jul 2012 12:31:50 +0200 Message-ID: <1342002726-18258-6-git-send-email-vasilis.liaskovitis@profitbricks.com> References: <1342002726-18258-1-git-send-email-vasilis.liaskovitis@profitbricks.com> Cc: avi@redhat.com, anthony@codemonkey.ws, gleb@redhat.com, imammedo@redhat.com, kevin@koconnor.net, wency@cn.fujitsu.com, Vasilis Liaskovitis To: qemu-devel@nongnu.org, kvm@vger.kernel.org, seabios@seabios.org Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:56955 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752989Ab2GKKcP (ORCPT ); Wed, 11 Jul 2012 06:32:15 -0400 Received: by mail-bk0-f46.google.com with SMTP id j10so891599bkw.19 for ; Wed, 11 Jul 2012 03:32:14 -0700 (PDT) In-Reply-To: <1342002726-18258-1-git-send-email-vasilis.liaskovitis@profitbricks.com> Sender: kvm-owner@vger.kernel.org List-ID: In order to hotplug memory between RamSize and BUILD_PCIMEM_START, the pci window needs to start at BUILD_PCIMEM_START (0xe0000000). Otherwise, the guest cannot online new dimms at those ranges due to pci_root window conflicts. (workaround for linux guest is booting with pci=nocrs) Signed-off-by: Vasilis Liaskovitis --- src/pciinit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/pciinit.c b/src/pciinit.c index 68f302a..0b11cbe 100644 --- a/src/pciinit.c +++ b/src/pciinit.c @@ -592,7 +592,7 @@ static void pci_region_map_entries(struct pci_bus *busses, struct pci_region *r) static void pci_bios_map_devices(struct pci_bus *busses) { - pcimem_start = RamSize; + pcimem_start = BUILD_PCIMEM_START; if (pci_bios_init_root_regions(busses)) { struct pci_region r64_mem, r64_pref; -- 1.7.9 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SouDW-0003Kg-Rt for qemu-devel@nongnu.org; Wed, 11 Jul 2012 06:32:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SouDP-0005pd-Ie for qemu-devel@nongnu.org; Wed, 11 Jul 2012 06:32:22 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:57641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SouDP-0005nm-Ct for qemu-devel@nongnu.org; Wed, 11 Jul 2012 06:32:15 -0400 Received: by mail-bk0-f45.google.com with SMTP id ji1so712841bkc.4 for ; Wed, 11 Jul 2012 03:32:14 -0700 (PDT) From: Vasilis Liaskovitis Date: Wed, 11 Jul 2012 12:31:50 +0200 Message-Id: <1342002726-18258-6-git-send-email-vasilis.liaskovitis@profitbricks.com> In-Reply-To: <1342002726-18258-1-git-send-email-vasilis.liaskovitis@profitbricks.com> References: <1342002726-18258-1-git-send-email-vasilis.liaskovitis@profitbricks.com> Subject: [Qemu-devel] [RFC PATCH v2 05/21][SeaBIOS] pciinit: Fix pcimem_start value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, kvm@vger.kernel.org, seabios@seabios.org Cc: gleb@redhat.com, Vasilis Liaskovitis , kevin@koconnor.net, avi@redhat.com, anthony@codemonkey.ws, imammedo@redhat.com In order to hotplug memory between RamSize and BUILD_PCIMEM_START, the pci window needs to start at BUILD_PCIMEM_START (0xe0000000). Otherwise, the guest cannot online new dimms at those ranges due to pci_root window conflicts. (workaround for linux guest is booting with pci=nocrs) Signed-off-by: Vasilis Liaskovitis --- src/pciinit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/pciinit.c b/src/pciinit.c index 68f302a..0b11cbe 100644 --- a/src/pciinit.c +++ b/src/pciinit.c @@ -592,7 +592,7 @@ static void pci_region_map_entries(struct pci_bus *busses, struct pci_region *r) static void pci_bios_map_devices(struct pci_bus *busses) { - pcimem_start = RamSize; + pcimem_start = BUILD_PCIMEM_START; if (pci_bios_init_root_regions(busses)) { struct pci_region r64_mem, r64_pref; -- 1.7.9