From: Peter Zijlstra <firstname.lastname@example.org> To: Frederic Weisbecker <email@example.com> Cc: Andrew Vagin <firstname.lastname@example.org>, email@example.com, Ingo Molnar <firstname.lastname@example.org>, Steven Rostedt <email@example.com>, Paul Mackerras <firstname.lastname@example.org>, Arnaldo Carvalho de Melo <email@example.com>, Arun Sharma <firstname.lastname@example.org> Subject: Re: [PATCH] trace: add ability to set a target task for events (v2) Date: Wed, 11 Jul 2012 16:33:41 +0200 [thread overview] Message-ID: <1342017221.3462.159.camel@twins> (raw) In-Reply-To: <20120711143121.GA17991@somewhere> On Wed, 2012-07-11 at 16:31 +0200, Frederic Weisbecker wrote: > On Wed, Jul 11, 2012 at 06:14:58PM +0400, Andrew Vagin wrote: > > A few events are interesting not only for a current task. > > For example, sched_stat_* are interesting for a task, which > > wake up. For this reason, it will be good, if such events will > > be delivered to a target task too. > > > > Now a target task can be set by using __perf_task(). > > > > The original idea and a draft patch belongs to Peter Zijlstra. > > > > I need this events for profiling sleep times. sched_switch is used for > > getting callchains and sched_stat_* is used for getting time periods. > > This events are combined in user space, then it can be analized by > > perf tools. > > We've talked about that numerous times. But I still don't really > understand why you're not using sched switch events and compute > the difference between schedule in and schedule out. > > I think you said that's because you got too much events with sched > switch. Are you loosing events? Otherwise I don't see why it's > a problem. > > Also the sched_stat_sleep event produce an event which period equals the > time slept. Internally, perf split this into as many events as that period > because the requested period for trace events is 1 by default. We probably > should allow to send events with a higher number than the one requested. This > this produce sometimes a huge pile of events, and that even often result in > tons of lost events. We definetly need to fix that. > > In the meantime you'll certainly get saner results by just recording > sched switch events. Not really, there's an arbitrary large delay between wakeup and getting scheduled back in, which is unrelated to the cause that you went to sleep. The wants the time between going to sleep and getting woken up, sched_switch simply doesn't give you that.
next prev parent reply other threads:[~2012-07-11 14:34 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-11 14:14 Andrew Vagin 2012-07-11 14:31 ` Frederic Weisbecker 2012-07-11 14:33 ` Peter Zijlstra [this message] 2012-07-11 14:36 ` Frederic Weisbecker 2012-07-11 14:38 ` Peter Zijlstra 2012-07-11 14:48 ` Frederic Weisbecker 2012-07-11 14:55 ` Peter Zijlstra 2012-07-11 15:07 ` Frederic Weisbecker 2012-07-11 15:12 ` Peter Zijlstra 2012-07-11 15:17 ` Frederic Weisbecker 2012-07-11 15:09 ` Peter Zijlstra 2012-07-31 17:58 ` [tip:perf/urgent] perf/trace: Add ability to set a target task for events tip-bot for Andrew Vagin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1342017221.3462.159.camel@twins \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] trace: add ability to set a target task for events (v2)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.