From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 00/81] modeset rework Date: Sun, 15 Jul 2012 14:13:41 +0100 Message-ID: <1342358035_1196@CP5-2952> References: <1342016944-23395-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D5259E801 for ; Sun, 15 Jul 2012 06:14:02 -0700 (PDT) In-Reply-To: <1342016944-23395-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Wed, 11 Jul 2012 16:27:43 +0200, Daniel Vetter wrote: > Or: How to fix cpu edp in 81 simple steps. Admittedly this includes some minor > detours. Let me quickly jump in with my demands: That modeset should detect failure and propagate that back to the user. The modesetting code has outgrown its origins of setting a couple of registers and be done, as we are now in the domain of fiddly link training and end-point negotations. So it is fragile, can conceivably fail and so the errors need to be reported rather than blindly assume the output is now working. So all of these nice new WARNs I'm seeing need to return error codes as well. -Chris -- Chris Wilson, Intel Open Source Technology Centre