From: Ben Widawsky <ben@bwidawsk.net>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Ben Widawsky <ben@bwidawsk.net>
Subject: [PATCH 0/4] [RFC] use HW watchdog timer
Date: Mon, 16 Jul 2012 11:51:55 -0700 [thread overview]
Message-ID: <1342464719-8790-1-git-send-email-ben@bwidawsk.net> (raw)
This was my pet project for the last few days, but I have to take a
break from working on it for now to do some real work ;-). The patches
compile, and pass a basic test, but that's about it. There is still
quite a bit of work left to make this useful. The easiest thing would be
to tie this into error state.
The idea is pretty simple. It uses the HW watchdog to set a timeout per
batchbuffer, instead of a global software watchdog.
Pros:
* Potential for per batch, or ring watchdog values. I believe when/if we
get to GPGPU workloads, this is particularly interesting.
* Batch granularity hang detection. This mostly just makes hang
detection and recovery a bit easier IMO.
Cons:
* Blit ring doesn't have an interrupt. This means we still need the
software watchdog, and it makes hang detection more complex. I've been
led to believe future HW *may* have this interrupt.
* Semaphores
I'm looking for feedback, mainly for Daniel, and Chris if this is worth
pursuing further when I have more time. The idea would be to eventually
use this to implement much of the ARB robustness requirements instead of
doing a bunch of request list processing.
Ben Widawsky (4):
drm/i915: Use HW watchdog for each batch
drm/i915: Turn on watchdog interrupts
drm/i915: Add a breadcrumb
drm/i915: Display the failing seqno
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_irq.c | 14 ++++++++++++++
drivers/gpu/drm/i915/i915_reg.h | 5 +++++
drivers/gpu/drm/i915/intel_ringbuffer.c | 34 ++++++++++++++++++++++++++++++---
drivers/gpu/drm/i915/intel_ringbuffer.h | 3 +++
5 files changed, 54 insertions(+), 4 deletions(-)
--
1.7.11.2
next reply other threads:[~2012-07-16 18:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 18:51 Ben Widawsky [this message]
2012-07-16 18:51 ` [PATCH 1/4] drm/i915: Use HW watchdog for each batch Ben Widawsky
2012-07-16 18:51 ` [PATCH 2/4] drm/i915: Turn on watchdog interrupts Ben Widawsky
2012-07-16 18:51 ` [PATCH 3/4] drm/i915: Add a breadcrumb Ben Widawsky
2012-07-16 18:51 ` [PATCH 4/4] drm/i915: Display the failing seqno Ben Widawsky
2012-07-16 20:16 ` [PATCH 0/4] [RFC] use HW watchdog timer Daniel Vetter
2012-07-17 11:12 ` Chris Wilson
2012-07-17 18:51 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342464719-8790-1-git-send-email-ben@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.