All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuah.khan@hp.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: fujita.tomonori@lab.ntt.co.jp,
	LKML <linux-kernel@vger.kernel.org>,
	akpm@linux-foundation.org, paul.gortmaker@windriver.com,
	bhelgaas@google.com, amwang@redhat.com, shuahkhan@gmail.com
Subject: Re: [PATCH RFC] swiotlb: Disable swiotlb overflow support when CONFIG_ISA is enabled
Date: Tue, 17 Jul 2012 12:27:27 -0600	[thread overview]
Message-ID: <1342549647.2539.29.camel@lorien2> (raw)
In-Reply-To: <20120716160119.GE13540@phenom.dumpdata.com>

On Mon, 2012-07-16 at 12:01 -0400, Konrad Rzeszutek Wilk wrote:

> > > The first goal is to figure out which of the drivers aren't doing this
> > > properly. This should be possible by just grepping for 'dma_map' and 
> > > seeing which ones don't do the 'dma_check' right after.
> > 

I did cscope searches two different ways on linux-next July 12th git

map_page - in this case I looked at all of the dma_ops.map_page() calls
to see if they are followed by dma_mapping_error() calls. Found the
following cases that don't check map_page() return value.

arch/powerpc/platforms/cell/iommu.c - dma_fixed_map_page()
drivers/net/ethernet/sun/niu.c - niu_rbr_add_page()
net/sunrpc/xprtrdma/svc_rdma_sendto.c - dma_map_xdr()

dma_map - in this case again I looked for calls to dma_map(). Found the
following cases where return isn't checked:

drivers/atm/fore200e.c
drivers/isdn/hardware/eicon/di.c

I am somewhat surprised to find only a few cases. Hoping I covered all
the bases, can you think of anything else I should look for before
concluding these are the cases that need fixing?

-- Shuah


  parent reply	other threads:[~2012-07-17 18:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-06 23:06 [PATCH RFC] swiotlb: Remove SWIOTLB overflow buffer support Shuah Khan
2012-07-09 20:25 ` Konrad Rzeszutek Wilk
2012-07-10 16:33   ` FUJITA Tomonori
2012-07-10 16:55   ` Shuah Khan
2012-07-10 17:32     ` Konrad Rzeszutek Wilk
2012-07-10 23:06       ` Shuah Khan
2012-07-10 23:13         ` Shuah Khan
2012-07-12 16:17       ` [PATCH RFC] swiotlb: Disable swiotlb overflow support when CONFIG_ISA is enabled Shuah Khan
2012-07-16 14:45         ` Konrad Rzeszutek Wilk
2012-07-16 15:48           ` Shuah Khan
2012-07-16 16:01             ` Konrad Rzeszutek Wilk
2012-07-16 16:47               ` Shuah Khan
2012-07-17 18:27               ` Shuah Khan [this message]
2012-07-17 20:13                 ` [PATCH] swiotlb: Disable swiotlb overflow support when CONFIG_ISA is disabled Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1342549647.2539.29.camel@lorien2 \
    --to=shuah.khan@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=amwang@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=shuahkhan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.