All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luciano Coelho <coelho@ti.com>
To: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org, Luis Rodriguez <mcgrof@gmail.com>
Subject: Re: [PATCH] cfg80211: Fix mutex locking in reg_last_request_cell_base
Date: Wed, 18 Jul 2012 17:46:02 +0300	[thread overview]
Message-ID: <1342622762.5363.41.camel@cumari.coelho.fi> (raw)
In-Reply-To: <1342615289-3088-1-git-send-email-mohammed@qca.qualcomm.com>

On Wed, 2012-07-18 at 18:11 +0530, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
> 
> should fix the following issue
> 
> 	[ 3229.815012] [ BUG: lock held when returning to user space! ]
> 	[ 3229.815016] 3.5.0-rc7-wl #28 Tainted: G        W  O
> 	[ 3229.815017]
> 	------------------------------------------------
> 	[ 3229.815019] wpa_supplicant/5783 is leaving the kernel with locks still held!
> 	[ 3229.815022] 1 lock held by wpa_supplicant/5783:
> 	[ 3229.815023]  #0: (reg_mutex){+.+.+.}, at: [<fa65834d>]
> 	reg_last_request_cell_base+0x1d/0x60 [cfg80211]
> 
> Cc: Luis Rodriguez <mcgrof@gmail.com>
> Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
> ---

Tested-by: Luciano Coelho <coelho@ti.com>

This actually also fixes a similar circular lock dependency bug when
starting AP mode with hostapd (which is the case I tested this patch
on): http://pastebin.com/AVczE1Ej

--
Luca.


  reply	other threads:[~2012-07-18 14:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18 12:41 [PATCH] cfg80211: Fix mutex locking in reg_last_request_cell_base Mohammed Shafi Shajakhan
2012-07-18 14:46 ` Luciano Coelho [this message]
2012-07-18 15:20   ` Mohammed Shafi
2012-07-18 15:04 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1342622762.5363.41.camel@cumari.coelho.fi \
    --to=coelho@ti.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    --cc=mohammed@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.