From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Hajnoczi Subject: [RFC v9 25/27] msix: fix irqchip breakage in msix_try_notify_from_thread() Date: Wed, 18 Jul 2012 16:07:52 +0100 Message-ID: <1342624074-24650-26-git-send-email-stefanha@linux.vnet.ibm.com> References: <1342624074-24650-1-git-send-email-stefanha@linux.vnet.ibm.com> Cc: , Anthony Liguori , Kevin Wolf , Paolo Bonzini , "Michael S. Tsirkin" , Asias He , Khoa Huynh , Stefan Hajnoczi To: Return-path: Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:56947 "EHLO e06smtp13.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754817Ab2GRPIu (ORCPT ); Wed, 18 Jul 2012 11:08:50 -0400 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 18 Jul 2012 16:08:49 +0100 Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6IF8kCU2130098 for ; Wed, 18 Jul 2012 16:08:46 +0100 Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6IF8jnW013723 for ; Wed, 18 Jul 2012 09:08:46 -0600 In-Reply-To: <1342624074-24650-1-git-send-email-stefanha@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Commit bd8b215bce453706c3951460cc7e6627ccb90314 removed #ifdef KVM_CAP_IRQCHIP from hw/msix.c after it turned out is not included since msix.o is built in libhw64/. Do the same for msix_try_notify_from_thread() since we do not have access to here and hence KVM_CAP_IRQCHIP is not defined. Signed-off-by: Stefan Hajnoczi --- hw/msix.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 3308604..0ed1013 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -511,12 +511,10 @@ bool msix_try_notify_from_thread(PCIDevice *dev, unsigned vector) if (unlikely(msix_is_masked(dev, vector))) { return false; } -#ifdef KVM_CAP_IRQCHIP if (likely(kvm_enabled() && kvm_irqchip_in_kernel())) { kvm_set_irq(dev->msix_irq_entries[vector].gsi, 1, NULL); return true; } -#endif return false; } -- 1.7.10.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrVs0-0006Ff-7y for qemu-devel@nongnu.org; Wed, 18 Jul 2012 11:09:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrVru-0000p1-Cf for qemu-devel@nongnu.org; Wed, 18 Jul 2012 11:08:56 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:59261) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrVru-0000oZ-0A for qemu-devel@nongnu.org; Wed, 18 Jul 2012 11:08:50 -0400 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 18 Jul 2012 16:08:49 +0100 Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6IF8j0o2547728 for ; Wed, 18 Jul 2012 16:08:45 +0100 Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6IF8jnQ013723 for ; Wed, 18 Jul 2012 09:08:45 -0600 From: Stefan Hajnoczi Date: Wed, 18 Jul 2012 16:07:52 +0100 Message-Id: <1342624074-24650-26-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1342624074-24650-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1342624074-24650-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [RFC v9 25/27] msix: fix irqchip breakage in msix_try_notify_from_thread() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Anthony Liguori , Stefan Hajnoczi , kvm@vger.kernel.org, "Michael S. Tsirkin" , Khoa Huynh , Paolo Bonzini , Asias He Commit bd8b215bce453706c3951460cc7e6627ccb90314 removed #ifdef KVM_CAP_IRQCHIP from hw/msix.c after it turned out is not included since msix.o is built in libhw64/. Do the same for msix_try_notify_from_thread() since we do not have access to here and hence KVM_CAP_IRQCHIP is not defined. Signed-off-by: Stefan Hajnoczi --- hw/msix.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 3308604..0ed1013 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -511,12 +511,10 @@ bool msix_try_notify_from_thread(PCIDevice *dev, unsigned vector) if (unlikely(msix_is_masked(dev, vector))) { return false; } -#ifdef KVM_CAP_IRQCHIP if (likely(kvm_enabled() && kvm_irqchip_in_kernel())) { kvm_set_irq(dev->msix_irq_entries[vector].gsi, 1, NULL); return true; } -#endif return false; } -- 1.7.10.4