From: Huang Ying <ying.huang@intel.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Chen Gong <gong.chen@linux.intel.com>,
"Xiao, Hui" <hui.xiao@linux.intel.com>,
Gary Hade <garyhade@us.ibm.com>,
tony.luck@intel.com, lenb@kernel.org, pluto@agmk.net,
linux-acpi@vger.kernel.org
Subject: Re: [RFC] ACPI, APEI: Fix incorrect bit width + offset check condition
Date: Thu, 19 Jul 2012 08:37:54 +0800 [thread overview]
Message-ID: <1342658274.9635.68.camel@yhuang-dev> (raw)
In-Reply-To: <20120718162846.25a64bf0@endymion.delvare>
On Wed, 2012-07-18 at 16:28 +0200, Jean Delvare wrote:
> On Wed, 18 Jul 2012 16:24:00 +0800, Chen Gong wrote:
> > > On Thu, 14 Jun 2012 14:14:30 +0800, Xiao, Hui wrote:
> > Now we have a final decision for this issue? Anyway, we need a patch to
> > fix our BIOS issue.
> >
> > Jean or Gary, if OK, would you please cook one patch to fix this issue?
>
> Ying's patch adding resource allocation time checks is already in:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=34ddeb035d704eafdcdb3cbc781894300136c3c4
> This addresses the log message flood issue.
>
> My own patch with one BIOS bug fixup was accepted by Len Brown and
> should go into kernel 3.6:
> https://bugzilla.kernel.org/show_bug.cgi?id=43282#c25
> (Not sure which tree this is.)
>
> So, as far as I am concerned, the functional issue is solved. From a
> performance perspective I think we could drop the run-time checks as
> they are now redundant.
Performance is not so important for these code. I keep the run-time
checks as the safe guard for future potential issues. If you don't like
it, we can add some comments to mark that it is redundant, just safe
guard and should be removed in the future.
Best Regards,
Huang Ying
prev parent reply other threads:[~2012-07-19 0:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 7:39 [RFC] ACPI, APEI: Fix incorrect bit width + offset check condition Xiao, Hui
2012-06-13 8:46 ` Jean Delvare
2012-06-13 10:44 ` Xiao, Hui
2012-06-14 7:53 ` Jean Delvare
2012-06-14 21:49 ` Gary Hade
2012-06-13 17:45 ` Gary Hade
2012-06-14 6:14 ` Xiao, Hui
2012-06-14 8:09 ` Jean Delvare
2012-06-14 16:32 ` Gary Hade
2012-06-15 11:28 ` Xiao, Hui
2012-07-18 8:24 ` Chen Gong
2012-07-18 14:28 ` Jean Delvare
2012-07-19 0:37 ` Huang Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342658274.9635.68.camel@yhuang-dev \
--to=ying.huang@intel.com \
--cc=garyhade@us.ibm.com \
--cc=gong.chen@linux.intel.com \
--cc=hui.xiao@linux.intel.com \
--cc=khali@linux-fr.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=pluto@agmk.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.