All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: shuah.khan@hp.com
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org, bhelgaas@google.com,
	isimatu.yasuaki@jp.fujitsu.com, liuj97@gmail.com,
	srivatsa.bhat@linux.vnet.ibm.com, prarit@redhat.com,
	imammedo@redhat.com, vijaymohan.pandarathil@hp.com,
	shuahkhan@gmail.com
Subject: Re: [PATCH 1/4] ACPI: Add acpi_pr_<level>() interfaces
Date: Thu, 19 Jul 2012 17:43:57 -0600	[thread overview]
Message-ID: <1342741437.3010.275.camel@misato.fc.hp.com> (raw)
In-Reply-To: <1342737168.6809.40.camel@lorien2>

On Thu, 2012-07-19 at 16:32 -0600, Shuah Khan wrote:
> On Thu, 2012-07-19 at 14:51 -0600, Toshi Kani wrote:
> 
> > If your concern is actually a performance bottleneck in acpi_get_name()
> > you found in the code, you should report it to the ACPI CA team.
> 
> I have tried my best to get you to understand the problems in bigger
> picture your patch set can exacerbate. Looking to somebody else to fix
> the problems doesn't help. It doesn't look like we can come to an
> agreement here, we just have to agree to disagree.

I am not asking someone to fix it.  I tried my best to explain that
acpi_get_name() does not lead any performance issue when it is called in
the error paths of ACPI drivers, and why we have to call it to obtain an
object path info for error analysis.  If you still believe there is a
performance issue in calling acpi_get_name() under this context, please
help us understand where the performance bottleneck is in the code.  (I
hope you just concerned it because it has "acpi_" prefix...) I will then
work on the issue with the ACPI CA team.

Thanks,
-Toshi



> caio,
> -- Shuah
> 



  reply	other threads:[~2012-07-19 23:48 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18 20:40 [PATCH 0/4] ACPI: hotplug messages improvement Toshi Kani
2012-07-18 20:40 ` [PATCH 1/4] ACPI: Add acpi_pr_<level>() interfaces Toshi Kani
2012-07-18 21:21   ` Joe Perches
2012-07-18 21:41     ` Toshi Kani
2012-07-18 21:54       ` Joe Perches
2012-07-18 22:08         ` Toshi Kani
2012-07-19  5:35           ` Moore, Robert
2012-07-19 14:36             ` Toshi Kani
2012-07-18 21:27   ` Joe Perches
2012-07-18 21:41     ` Toshi Kani
2012-07-18 22:06       ` Joe Perches
2012-07-18 22:11         ` Toshi Kani
2012-07-18 21:59   ` Shuah Khan
2012-07-18 22:26     ` Toshi Kani
2012-07-18 22:40       ` Shuah Khan
2012-07-18 22:52         ` Toshi Kani
2012-07-18 23:18           ` Shuah Khan
2012-07-19  0:38             ` Toshi Kani
2012-07-19 16:15               ` Shuah Khan
2012-07-19 16:34                 ` Joe Perches
2012-07-20 15:52                   ` Toshi Kani
2012-07-19 17:28                 ` Toshi Kani
2012-07-19 19:25                   ` Shuah Khan
2012-07-19 20:51                     ` Toshi Kani
2012-07-19 22:32                       ` Shuah Khan
2012-07-19 23:43                         ` Toshi Kani [this message]
2012-07-24 15:55                           ` Toshi Kani
2012-07-24 16:08                             ` Toshi Kani
2012-07-18 22:49       ` Joe Perches
2012-07-18 23:32         ` Toshi Kani
2012-07-18 20:40 ` [PATCH 2/4] ACPI: Update CPU hotplug messages Toshi Kani
2012-07-18 20:40 ` [PATCH 3/4] ACPI: Update Memory " Toshi Kani
2012-07-18 20:40 ` [PATCH 4/4] ACPI: Update Container " Toshi Kani
2012-07-25  3:45 ` [PATCH 0/4] ACPI: hotplug messages improvement Yasuaki Ishimatsu
2012-07-25  3:45   ` Yasuaki Ishimatsu
2012-07-25 15:26   ` Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1342741437.3010.275.camel@misato.fc.hp.com \
    --to=toshi.kani@hp.com \
    --cc=bhelgaas@google.com \
    --cc=imammedo@redhat.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuj97@gmail.com \
    --cc=prarit@redhat.com \
    --cc=shuah.khan@hp.com \
    --cc=shuahkhan@gmail.com \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=vijaymohan.pandarathil@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.