From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 1 of 3 v5/leftover] libxl: enable automatic placement of guests on NUMA nodes [and 1 more messages] Date: Sat, 21 Jul 2012 03:46:32 +0200 Message-ID: <1342835192.4667.27.camel@Solace> References: <0411b2cebd725b193465.1341932614@Solace> <20485.35590.105351.434937@mariner.uk.xensource.com> <5fa66c8b9093399e5bc3.1342458792@Solace> <20485.43293.833036.352186@mariner.uk.xensource.com> <1342570947.11794.92.camel@Abyss> <1342602839.26734.6.camel@zakaz.uk.xensource.com> <1342604616.19530.123.camel@Solace> <1342605184.26734.19.camel@zakaz.uk.xensource.com> <20486.38718.474388.724787@mariner.uk.xensource.com> <5006BCC1.7050001@amd.com> <20488.7456.990576.233871@mariner.uk.xensource.com> <500853CE.8090500@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8585274292851234252==" Return-path: In-Reply-To: <500853CE.8090500@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andre Przywara Cc: Ian Campbell , Stefano Stabellini , George Dunlap , Juergen Gross , Ian Jackson , xen-devel List-Id: xen-devel@lists.xenproject.org --===============8585274292851234252== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-JSg2pQ9S6x3i72MLEq9w" --=-JSg2pQ9S6x3i72MLEq9w Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2012-07-19 at 20:37 +0200, Andre Przywara wrote: > > But it's OK, we don't need to panic. We just need a safety catch > > which stops this algorithm running in situations where it won't work. > > Following a discussion with Dario, AIUI he plans to implement a rule > > that it will bail on systems with more than 8 NUMA nodes. > > > > That is releasable in 4.2 and ought to be satisfactory for you ? >=20 I did right that. Honestly, I computed the exact amount of steps the algorithm needs in the worst case (i.e., searching all the combinations of all the sizes) for 8 and 16 nodes. 8 nodes means 256 steps, 16 nodes means 65536, so I think both could work, especially after the optimization I put in the version I just released (it does not uses that large array of combinations and does not need to always perform all the steps any longer). However, as agreed, I put an "if (nr_nodes <=3D 8)" there... If a 16 nodes machine will ever appear, we'll decide what to do. > Absolutely, that's fine. I just wanted to make sure that we don't drop= =20 > the patches at all because of the theoretical fear of a large NUMA box= =20 > lingering somewhere around the corner... >=20 :-) Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-JSg2pQ9S6x3i72MLEq9w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlAKCfgACgkQk4XaBE3IOsTl/QCgqb5y6JgFmSmAwiR1H9bCYEf5 iVEAn3z6W3dzN0JUo/6fR+qqBLOarYbP =qfVa -----END PGP SIGNATURE----- --=-JSg2pQ9S6x3i72MLEq9w-- --===============8585274292851234252== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8585274292851234252==--