From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [PATCH] net/mlx: update C compliance standard
Date: Sun, 2 Jul 2017 00:12:37 +0000
Message-ID: <1342F388-7481-4007-937B-F804452E3757@mellanox.com>
References: <4bc47a8c50dc528f8061d95cdd0c0934e4e40b38.1498843072.git.adrien.mazarguil@6wind.com>
 <c3e5f96d-bc1f-6cf6-b8b3-b5d0a13e3d20@intel.com>
 <1C0F2AC4-AF9D-4A02-A35A-F70577FE67B5@mellanox.com>
 <7672F9BE-1782-4F1A-B4B7-F28C82C34FD5@mellanox.com>
 <45a80418-acd5-42d7-4319-365bed329fa9@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 =?iso-8859-1?Q?N=E9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr30070.outbound.protection.outlook.com [40.107.3.70])
 by dpdk.org (Postfix) with ESMTP id 5C0812BAF
 for <dev@dpdk.org>; Sun,  2 Jul 2017 02:12:40 +0200 (CEST)
In-Reply-To: <45a80418-acd5-42d7-4319-365bed329fa9@intel.com>
Content-Language: en-US
Content-ID: <4C9258E6E4EF5D418BC9930340DCB205@eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> On Jul 1, 2017, at 8:58 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>=20
> On 6/30/2017 7:25 PM, Yongseok Koh wrote:
>>=20
>>> On Jun 30, 2017, at 11:14 AM, Yongseok Koh <yskoh@mellanox.com> wrote:
>>>=20
>>>=20
>>>> On Jun 30, 2017, at 10:47 AM, Ferruh Yigit <ferruh.yigit@intel.com> wr=
ote:
>>>>=20
>>>> On 6/30/2017 6:19 PM, Adrien Mazarguil wrote:
>>>>> This commit addresses a compilation issue against Glibc >=3D 2.25, wh=
ich
>>>>> implements assert() through a nonstandard ({ }) construct. Such const=
ructs
>>>>> can normally not be used without __extension__ keyword when -pedantic=
 is
>>>>> enabled, as is the case when compiling mlx4 and mlx5 PMDs in debug mo=
de.
>>>>>=20
>>>>> While assert.h checks for the compiler ability to support GNU extensi=
ons,
>>>>> Clang, unlike GCC, does not allow the above syntax when combining
>>>>> -std=3Dgnu99 with -pedantic.
>>>>>=20
>>>>> Work around missing keyword by moving these PMDs to a stricter compli=
ance
>>>>> standard without GNU extensions but properly checked by Glibc. Doing =
so is
>>>>> supported on the DPDK side since includes have been cleaned up.
>>>>>=20
>>>>> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>>>>=20
>>>> Applied to dpdk-next-net/master, thanks.
>>> This breaks debug-enabled build of mlx5 as mlx5 isn't ready yet!
>> Specifically, the following errors happen. It might be better to later m=
ake the
>> change for mlx5 with further cleanup.
>=20
> I don't see build errors.
> Patch is requested to fix mlx DEBUG builds [1]. Can you please give more
> details how to reproduce build error?

Mine is on CentOS 7.3 and gcc is "version 4.8.5 20150623 (Red Hat 4.8.5-11)=
 (GCC)"
Adrien chatted with me and he is already preparing a simple patch. I've als=
o
verified his patch fixed the issue.

Thanks,
Yongseok=