All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Alex Shi <alex.shi@intel.com>, X86-ML <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Borislav Petkov <borislav.petkov@amd.com>
Subject: [PATCH v1 1/4] x86, CPU: Fixup tlb_flushall_shift formatting
Date: Mon,  6 Aug 2012 19:00:36 +0200	[thread overview]
Message-ID: <1344272439-29080-2-git-send-email-bp@amd64.org> (raw)
In-Reply-To: <1344272439-29080-1-git-send-email-bp@amd64.org>

From: Borislav Petkov <borislav.petkov@amd.com>

The TLB characteristics appeared like this in dmesg:

[    0.065817] Last level iTLB entries: 4KB 512, 2MB 1024, 4MB 512
[    0.065817] Last level dTLB entries: 4KB 1024, 2MB 1024, 4MB 512
[    0.065817] tlb_flushall_shift is 0xffffffff

where tlb_flushall_shift is actually -1 but dumped as a hex number.
However, the Kconfig option CONFIG_DEBUG_TLBFLUSH and the rest of the
code treats this as a signed decimal and states "If you set it to -1,
the code flushes the whole TLB unconditionally."

So, fix its formatting in accordance with the other references to it.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Acked-by: Alex Shi <alex.shi@intel.com>
---
 arch/x86/kernel/cpu/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 46d8786d655e..d239977f361f 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -474,7 +474,7 @@ void __cpuinit cpu_detect_tlb(struct cpuinfo_x86 *c)
 
 	printk(KERN_INFO "Last level iTLB entries: 4KB %d, 2MB %d, 4MB %d\n" \
 		"Last level dTLB entries: 4KB %d, 2MB %d, 4MB %d\n"	     \
-		"tlb_flushall_shift is 0x%x\n",
+		"tlb_flushall_shift: %d\n",
 		tlb_lli_4k[ENTRIES], tlb_lli_2m[ENTRIES],
 		tlb_lli_4m[ENTRIES], tlb_lld_4k[ENTRIES],
 		tlb_lld_2m[ENTRIES], tlb_lld_4m[ENTRIES],
-- 
1.7.11.rc1


  reply	other threads:[~2012-08-06 17:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-06 17:00 [PATCH v1 0/4] x86, CPU: TLB flushall shift, the AMD side Borislav Petkov
2012-08-06 17:00 ` Borislav Petkov [this message]
2012-08-07  3:07   ` [tip:x86/mm] x86, cpu: Fixup tlb_flushall_shift formatting tip-bot for Borislav Petkov
2012-08-06 17:00 ` [PATCH v1 2/4] x86, CPU: Push TLB detection CPUID check down Borislav Petkov
2012-08-07  0:35   ` Alex Shi
2012-08-07  3:08   ` [tip:x86/mm] x86, cpu: " tip-bot for Borislav Petkov
2012-08-06 17:00 ` [PATCH v1 3/4] x86, CPU: Add AMD TLB size detection Borislav Petkov
2012-08-07  3:09   ` [tip:x86/mm] x86, cpu: " tip-bot for Borislav Petkov
2012-08-06 17:00 ` [PATCH v1 4/4] x86, CPU: Preset default tlb_flushall_shift on AMD Borislav Petkov
2012-08-07  3:10   ` [tip:x86/mm] x86, cpu: " tip-bot for Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344272439-29080-2-git-send-email-bp@amd64.org \
    --to=bp@amd64.org \
    --cc=alex.shi@intel.com \
    --cc=borislav.petkov@amd.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.