Re: [PATCH] Avoid crippled getpass function on Solaris

From: Ben Walton <bwalton@artsci.utoronto.ca>
To: Jeff King <peff@peff.net>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
	Junio C Hamano <gitster@pobox.com>, git <git@vger.kernel.org>,
	Tay Ray Chuan <rctay89@gmail.com>
Subject: Re: [PATCH] Avoid crippled getpass function on Solaris
Date: Mon, 06 Aug 2012 23:01:55 -0400	[thread overview]
Message-ID: <1344308342-sup-4817@pinkfloyd.chass.utoronto.ca> (raw)
In-Reply-To: <20120807003541.GA18219@sigill.intra.peff.net>

Excerpts from Jeff King's message of Mon Aug 06 20:35:41 -0400 2012:

> ---
>  compat/terminal.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/compat/terminal.c b/compat/terminal.c
> index 6d16c8f..bbb038d 100644
> --- a/compat/terminal.c
> +++ b/compat/terminal.c
> @@ -59,6 +59,7 @@ char *git_terminal_prompt(const char *prompt, int echo)
>  
>      r = strbuf_getline(&buf, fh, '\n');
>      if (!echo) {
> +        fseek(fh, SEEK_CUR, 0);
>          putc('\n', fh);
>          fflush(fh);
>      }

Acked-by: Ben Walton <bwalton@artsci.utoronto.ca>

That looks good to me.  I'm able to clone a password protected https
repository and the prompting works as I'd expect.

Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302