From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754164Ab2HGMbX (ORCPT ); Tue, 7 Aug 2012 08:31:23 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53648 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751944Ab2HGMbV (ORCPT ); Tue, 7 Aug 2012 08:31:21 -0400 From: Mel Gorman To: Linux-MM Cc: Rik van Riel , Minchan Kim , Jim Schutt , LKML , Mel Gorman Subject: [PATCH 1/6] mm: compaction: Update comment in try_to_compact_pages Date: Tue, 7 Aug 2012 13:31:12 +0100 Message-Id: <1344342677-5845-2-git-send-email-mgorman@suse.de> X-Mailer: git-send-email 1.7.9.2 In-Reply-To: <1344342677-5845-1-git-send-email-mgorman@suse.de> References: <1344342677-5845-1-git-send-email-mgorman@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The comment about order applied when the check was order > PAGE_ALLOC_COSTLY_ORDER which has not been the case since [c5a73c3d: thp: use compaction for all allocation orders]. Fixing the comment while I'm in the general area. Signed-off-by: Mel Gorman --- mm/compaction.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index b39ede1..95ca967 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -759,11 +759,7 @@ unsigned long try_to_compact_pages(struct zonelist *zonelist, struct zone *zone; int rc = COMPACT_SKIPPED; - /* - * Check whether it is worth even starting compaction. The order check is - * made because an assumption is made that the page allocator can satisfy - * the "cheaper" orders without taking special steps - */ + /* Check if the GFP flags allow compaction */ if (!order || !may_enter_fs || !may_perform_io) return rc; -- 1.7.9.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx134.postini.com [74.125.245.134]) by kanga.kvack.org (Postfix) with SMTP id 7F3786B004D for ; Tue, 7 Aug 2012 08:31:22 -0400 (EDT) From: Mel Gorman Subject: [PATCH 1/6] mm: compaction: Update comment in try_to_compact_pages Date: Tue, 7 Aug 2012 13:31:12 +0100 Message-Id: <1344342677-5845-2-git-send-email-mgorman@suse.de> In-Reply-To: <1344342677-5845-1-git-send-email-mgorman@suse.de> References: <1344342677-5845-1-git-send-email-mgorman@suse.de> Sender: owner-linux-mm@kvack.org List-ID: To: Linux-MM Cc: Rik van Riel , Minchan Kim , Jim Schutt , LKML , Mel Gorman The comment about order applied when the check was order > PAGE_ALLOC_COSTLY_ORDER which has not been the case since [c5a73c3d: thp: use compaction for all allocation orders]. Fixing the comment while I'm in the general area. Signed-off-by: Mel Gorman --- mm/compaction.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index b39ede1..95ca967 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -759,11 +759,7 @@ unsigned long try_to_compact_pages(struct zonelist *zonelist, struct zone *zone; int rc = COMPACT_SKIPPED; - /* - * Check whether it is worth even starting compaction. The order check is - * made because an assumption is made that the page allocator can satisfy - * the "cheaper" orders without taking special steps - */ + /* Check if the GFP flags allow compaction */ if (!order || !may_enter_fs || !may_perform_io) return rc; -- 1.7.9.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org