All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
Subject: [PATCH 3/6] i2c: designware: Fix a possible NULL pointer access
Date: Thu, 9 Aug 2012 19:07:44 +0530	[thread overview]
Message-ID: <1344519467-14295-4-git-send-email-shubhrajyoti@ti.com> (raw)
In-Reply-To: <1344519467-14295-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>

platform_get_resource uses pdev so move the function
platform_set_drvdata(pdev, NULL) after the get_resource.

Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
---
untested

 drivers/i2c/busses/i2c-designware-platdrv.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 0506fef..4f03eae 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -174,7 +174,6 @@ static int __devexit dw_i2c_remove(struct platform_device *pdev)
 	struct dw_i2c_dev *dev = platform_get_drvdata(pdev);
 	struct resource *mem;
 
-	platform_set_drvdata(pdev, NULL);
 	i2c_del_adapter(&dev->adapter);
 	put_device(&pdev->dev);
 
@@ -188,6 +187,7 @@ static int __devexit dw_i2c_remove(struct platform_device *pdev)
 
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	release_mem_region(mem->start, resource_size(mem));
+	platform_set_drvdata(pdev, NULL);
 	return 0;
 }
 
-- 
1.7.5.4

  parent reply	other threads:[~2012-08-09 13:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-09 13:37 [PATCH 0/6] I2C cleanup Shubhrajyoti D
     [not found] ` <1344519467-14295-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-08-09 13:37   ` [PATCH 1/6] i2c: omap: Prevent NULL pointer dereference in remove Shubhrajyoti D
     [not found]     ` <1344519467-14295-2-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-08-09 13:48       ` Shubhrajyoti Datta
2012-08-18 10:09       ` Wolfram Sang
     [not found]         ` <20120818100923.GD24812-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-08-18 13:45           ` Shubhrajyoti Datta
     [not found]             ` <CAM=Q2csCuf1LBuf2T8wnthXC_eSxW_b88XmJ07jzegbJOr3xMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-18 18:39               ` Wolfram Sang
2012-08-09 13:37   ` [PATCH 2/6] i2c-xiic: Fix a possible NULL pointer access Shubhrajyoti D
     [not found]     ` <1344519467-14295-3-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-08-18 10:17       ` Wolfram Sang
     [not found]         ` <20120818101752.GE24812-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-08-18 13:22           ` Shubhrajyoti Datta
     [not found]             ` <CAM=Q2cvebZc_3ja+K=4v+hC4ttf5r_jT=xVVtJ=kQtsRwdZtUA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-18 13:49               ` Shubhrajyoti Datta
2012-08-09 13:37   ` Shubhrajyoti D [this message]
2012-08-09 13:37   ` [PATCH 4/6] i2c: at91: " Shubhrajyoti D
2012-08-09 13:37   ` [PATCH 5/6] i2c-puv3: " Shubhrajyoti D
2012-08-09 13:37   ` [PATCH 6/6] i2c: davinci: " Shubhrajyoti D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344519467-14295-4-git-send-email-shubhrajyoti@ti.com \
    --to=shubhrajyoti-l0cymroini0@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.