From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 6/9] KVM: arm/arm64: use a vcpu request on irq injection Date: Tue, 4 Apr 2017 20:59:02 +0200 Message-ID: <1344d869-8de5-86e7-764c-3f19ad59b55e@redhat.com> References: <20170331160658.4331-1-drjones@redhat.com> <20170331160658.4331-7-drjones@redhat.com> <20170404174208.GB31208@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: marc.zyngier@arm.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org To: Christoffer Dall , Andrew Jones Return-path: In-Reply-To: <20170404174208.GB31208@cbox> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org On 04/04/2017 19:42, Christoffer Dall wrote: > > this is not going to be called when we don't have the vgic, which means > that if vcpu_interrupt_line() is used as you modify it above, the > request will never get cleared. Heh, I'll stop pretending I can give positive reviews of ARM patches and keep bash^Wproviding constructive criticism. :) In fact, I forgot to add that x86 recently moved to request-less kvm_vcpu_kick when hardware interrupt injection is available. This was after I noticed that requests were just used as a workaround for incorrect ordering of local_irq_disable, vcpu->mode=IN_GUEST_MODE, and so on. Paolo