All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Aaron Sierra <asierra@xes-inc.com>
Cc: Guenter Roeck <guenter@roeck-us.net>,
	linux-mtd@lists.infradead.org,
	Lew Glendenning <lglendenning@lnxi.com>
Subject: Re: [PATCH 2/2] mtd: esb2rom: rework ROM scanning and resources
Date: Fri, 17 Aug 2012 14:49:38 +0300	[thread overview]
Message-ID: <1345204178.27859.61.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <848a19c3-8f67-44f1-89ec-ac89e3a95035@zimbra>

[-- Attachment #1: Type: text/plain, Size: 913 bytes --]

On Thu, 2012-07-12 at 16:50 -0500, Aaron Sierra wrote:
> This patch collapses the various 4MB limit workarounds of the original
> driver to a single limit when probing the Decode Enable Register. This
> allows the driver to request an iomem region no larger than 4MB and no
> larger than needed. The Intel 3100 chipset hardware that I test on only
> has a 1MB ROM region and I experienced resource conflict warnings with
> the BIOS and a kernel call trace on each boot without this change.
> 
> It also changes the way the ROM region is requested so that it requires
> less manual resource structure manipulation and no longer always fails
> for me.

If this is an independent fix, make it to go first, so it could be
applied independently. Also, if you want make it more probable that
someone review it - please, try to split it on several smaller patches.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2012-08-17 11:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <91f4cca2-bcce-46aa-b69a-107fdce3ec73@zimbra>
2012-07-12 21:50 ` [PATCH 2/2] mtd: esb2rom: rework ROM scanning and resources Aaron Sierra
2012-08-17 11:49   ` Artem Bityutskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345204178.27859.61.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=asierra@xes-inc.com \
    --cc=guenter@roeck-us.net \
    --cc=lglendenning@lnxi.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.