From: Steven Whitehouse <swhiteho@redhat.com>
To: Xi Wang <xi.wang@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] decnet: fix shutdown parameter checking
Date: Mon, 27 Aug 2012 10:16:41 +0100 [thread overview]
Message-ID: <1346059001.2703.7.camel@menhir> (raw)
In-Reply-To: <1346035027-2347-1-git-send-email-xi.wang@gmail.com>
On Sun, 2012-08-26 at 22:37 -0400, Xi Wang wrote:
> The allowed value of "how" is SHUT_RD/SHUT_WR/SHUT_RDWR (0/1/2),
> rather than SHUTDOWN_MASK (3).
>
> Signed-off-by: Xi Wang <xi.wang@gmail.com>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Although it could be argued that we should also continue to accept the
value 3 just in case there is any userland software out there which
sends that value,
Steve.
> ---
> net/decnet/af_decnet.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c
> index 2ba1a28..307c322 100644
> --- a/net/decnet/af_decnet.c
> +++ b/net/decnet/af_decnet.c
> @@ -1313,10 +1313,10 @@ static int dn_shutdown(struct socket *sock, int how)
> if (scp->state == DN_O)
> goto out;
>
> - if (how != SHUTDOWN_MASK)
> + if (how != SHUT_RDWR)
> goto out;
>
> - sk->sk_shutdown = how;
> + sk->sk_shutdown = SHUTDOWN_MASK;
> dn_destroy_sock(sk);
> err = 0;
>
next prev parent reply other threads:[~2012-08-27 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 2:37 [PATCH] decnet: fix shutdown parameter checking Xi Wang
2012-08-27 9:16 ` Steven Whitehouse [this message]
2012-08-31 19:57 ` David Miller
2012-09-05 8:37 ` Steven Whitehouse
2012-09-05 17:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346059001.2703.7.camel@menhir \
--to=swhiteho@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.