From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8Hmi-0003t6-Hg for qemu-devel@nongnu.org; Sun, 02 Sep 2012 17:32:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8Hmh-0006Qe-3c for qemu-devel@nongnu.org; Sun, 02 Sep 2012 17:32:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8Hmg-0006Pw-Qj for qemu-devel@nongnu.org; Sun, 02 Sep 2012 17:32:47 -0400 From: =?UTF-8?q?S=C3=B8ren=20Sandmann=20Pedersen?= Date: Sun, 2 Sep 2012 17:35:22 -0400 Message-Id: <1346621726-11313-3-git-send-email-ssp@redhat.com> In-Reply-To: <1346621726-11313-1-git-send-email-ssp@redhat.com> References: <5040688D.5070707@redhat.com> <1346621726-11313-1-git-send-email-ssp@redhat.com> Subject: [Qemu-devel] [PATCH-v2 spice-protocol 2/2] Add new client_present and client capabilities fields to QXLRom List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, spice-devel@lists.freedesktop.org Cc: kraxel@redhat.com, =?UTF-8?q?S=C3=B8ren=20Sandmann=20Pedersen?= The client_present field is a byte that is set of non-zero when a client is connected and to zero when no client is connected. The client_capabilities[58] array contains 464 bits that indicate the capabilities of the client. Each bit corresponds to a SPICE_DISPLAY_CAP_* capability. In particular, if the client has capability C, then bit (C % 8) in byte (C / 8) is set. The capability bits only have a defined meaning when a client is connected, ie., when client_present is non-zero. The number 58 was chosen to fill out a cache line in QXLRom. A new QXL_INTERRUPT_CLIENT interrupt is defined, which will be raised whenever a client connects or disconnects. --- spice/qxl_dev.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index 1292767..50784dc 100644 --- a/spice/qxl_dev.h +++ b/spice/qxl_dev.h @@ -148,7 +148,9 @@ typedef struct SPICE_ATTR_PACKED QXLRom { uint8_t slot_gen_bits; uint8_t slot_id_bits; uint8_t slot_generation; - uint8_t padding[3]; /* Padding to 32bit align */ + /* appended for qxl-4 */ + uint8_t client_present; + uint8_t client_capabilities[58]; } QXLRom; /* qxl-1 compat: fixed */ @@ -231,6 +233,7 @@ SPICE_RING_DECLARE(QXLReleaseRing, uint64_t, QXL_RELEASE_RING_SIZE); #define QXL_INTERRUPT_CURSOR (1 << 1) #define QXL_INTERRUPT_IO_CMD (1 << 2) #define QXL_INTERRUPT_ERROR (1 << 3) +#define QXL_INTERRUPT_CLIENT (1 << 4) /* qxl-1 compat: append only */ typedef struct SPICE_ATTR_PACKED QXLRam { -- 1.7.11.4