From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org, a1bert@atlas.cz
Subject: Re: Fw: [Bug 47021] New: kernel panic with l2tpv3 & mtu > 1500
Date: Tue, 04 Sep 2012 21:52:14 +0200 [thread overview]
Message-ID: <1346788334.13121.82.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120904090756.71b34feb@nehalam.linuxnetplumber.net>
From: Eric Dumazet <edumazet@google.com>
On Tue, 2012-09-04 at 09:07 -0700, Stephen Hemminger wrote:
>
> Begin forwarded message:
>
> Date: Tue, 4 Sep 2012 16:06:06 +0000 (UTC)
> From: bugzilla-daemon@bugzilla.kernel.org
> To: shemminger@linux-foundation.org
> Subject: [Bug 47021] New: kernel panic with l2tpv3 & mtu > 1500
>
>
> https://bugzilla.kernel.org/show_bug.cgi?id=47021
>
> Summary: kernel panic with l2tpv3 & mtu > 1500
> Product: Networking
> Version: 2.5
> Kernel Version: 3.2.28
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: Other
> AssignedTo: shemminger@linux-foundation.org
> ReportedBy: a1bert@atlas.cz
> Regression: No
>
>
> first l2tpv3 packet that enters physical device with MTU > 1500 causes kernel
> panic
>
> tunel created using:
>
> l2tpv3tun add tunnel tunnel_id 1 peer_tunnel_id 1 encap udp udp_sport 5001
> udp_dport 5001 local 192.168.1.1 remote 192.168.1.2
>
> l2tpv3tun add session tunnel_id 1 session_id 1 peer_session_id 1 dev l2tpeth1
>
>
> reproducible: always
>
Seems following patch is needed, not sure if it helps
[PATCH] l2tp: fix a typo in l2tp_eth_dev_recv()
While investigating l2tp bug, I hit a bug in eth_type_trans(),
because not enough bytes were pulled in skb head.
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
net/l2tp/l2tp_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/l2tp/l2tp_eth.c b/net/l2tp/l2tp_eth.c
index f9ee74d..3bfb34a 100644
--- a/net/l2tp/l2tp_eth.c
+++ b/net/l2tp/l2tp_eth.c
@@ -153,7 +153,7 @@ static void l2tp_eth_dev_recv(struct l2tp_session *session, struct sk_buff *skb,
print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, skb->data, length);
}
- if (!pskb_may_pull(skb, sizeof(ETH_HLEN)))
+ if (!pskb_may_pull(skb, ETH_HLEN))
goto error;
secpath_reset(skb);
next prev parent reply other threads:[~2012-09-04 19:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 16:07 Fw: [Bug 47021] New: kernel panic with l2tpv3 & mtu > 1500 Stephen Hemminger
2012-09-04 19:52 ` Eric Dumazet [this message]
2012-09-04 19:54 ` Stephen Hemminger
2012-09-04 20:57 ` Eric Dumazet
2012-09-05 7:45 ` a1
2012-09-05 8:34 ` Eric Dumazet
2012-09-04 19:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346788334.13121.82.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=a1bert@atlas.cz \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.