All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajagopal Venkat <rajagopal.venkat at linaro.org>
To: powertop@lists.01.org
Subject: [Powertop] [PATCH] Fix timer and work perf events timestamp tracing
Date: Wed, 05 Sep 2012 15:52:34 +0530	[thread overview]
Message-ID: <1346840555-18457-1-git-send-email-rajagopal.venkat@linaro.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1894 bytes --]

Incorrect timer and work perf events timestamp tracing is one
of the reason for reporting usage over 100%. This patch will
resolve the issue by
- rejecting the events for which entry timestamp is not recorded.
Currently these events exit timestamp itself is considered as
usage period resulting in over 100% usage.
- clearing event timestamps from global map at the end of each
measurement to avoid collision with earlier recorded timestamps.

Signed-off-by: Rajagopal Venkat <rajagopal.venkat(a)linaro.org>
---
 src/process/timer.cpp | 5 ++++-
 src/process/work.cpp  | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/process/timer.cpp b/src/process/timer.cpp
index 8917490..db074c4 100644
--- a/src/process/timer.cpp
+++ b/src/process/timer.cpp
@@ -79,7 +79,8 @@ uint64_t timer::done(uint64_t time, uint64_t timer_struct)
 {
 	int64_t delta;
 
-	if (running_since[timer_struct] > time)
+	if (running_since.find(timer_struct) == running_since.end() ||
+			running_since[timer_struct] > time)
 		return 0;
 
 	delta = time - running_since[timer_struct];
@@ -147,6 +148,8 @@ void clear_timers(void)
 		all_timers.erase(it);
 		it = all_timers.begin();
 	}
+
+	running_since.clear();
 }
 
 bool timer::is_deferred(void)
diff --git a/src/process/work.cpp b/src/process/work.cpp
index 82f13a2..e436643 100644
--- a/src/process/work.cpp
+++ b/src/process/work.cpp
@@ -56,7 +56,8 @@ uint64_t work::done(uint64_t time, uint64_t work_struct)
 {
 	int64_t delta;
 
-	if (running_since[work_struct] > time)
+	if (running_since.find(work_struct) == running_since.end() ||
+			running_since[work_struct] > time)
 		return 0;
 
 	delta = time - running_since[work_struct];
@@ -102,6 +103,8 @@ void clear_work(void)
 		all_work.erase(it);
 		it = all_work.begin();
 	}
+
+	running_since.clear();
 }
 
 
-- 
1.7.11.3


             reply	other threads:[~2012-09-05 10:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 10:22 Rajagopal Venkat [this message]
2012-09-05 11:28 [Powertop] [PATCH] Fix timer and work perf events timestamp tracing Viresh Kumar
2012-09-05 12:44 Sergey Senozhatsky
2012-09-05 15:12 Chris Ferron
2012-09-05 16:56 Rajagopal Venkat
2012-09-05 17:09 Arjan van de Ven
2012-09-05 17:19 Rajagopal Venkat
2012-09-05 17:22 Arjan van de Ven
2012-09-05 17:45 Rajagopal Venkat
2012-09-05 18:06 Arjan van de Ven
2012-09-06 13:42 Rajagopal Venkat
2012-09-06 13:51 Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346840555-18457-1-git-send-email-rajagopal.venkat@linaro.org \
    --to=powertop@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.