From: Steven Rostedt <rostedt@goodmis.org>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: does gcc gives a false warning in kernel/trace/trace_events_filter.c ?
Date: Thu, 06 Sep 2012 13:31:16 -0400 [thread overview]
Message-ID: <1346952676.1680.44.camel@gandalf.local.home> (raw)
In-Reply-To: <5048D0E5.20103@gmx.de>
On Thu, 2012-09-06 at 18:35 +0200, Toralf Förster wrote:
> I filed a bug report
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54495
> and got this answer :
>
> --- Comment #1 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2012-09-05 22:14:00 UTC ---
> But if the call to ftrace_function_filter_re sets re_cnt to 0, then ret indeed
> will be used uninitialized AFAICT. What am I missing?
>
That I think we are looking at two different code bases ;-)
I've been looking at what's been queued for 3.7 and not what's in
mainline. If you look at tip/master, or even linux-next, you'll find:
commit 92d8d4a8b0f "tracing/filter: Add missing initialization"
Which does:
static int __ftrace_function_set_filter(int filter, char *buf, int len,
struct function_filter_data *data)
{
- int i, re_cnt, ret;
+ int i, re_cnt, ret = -EINVAL;
int *reset;
char **re;
Thus, you were correct. This could have been marked urgent, but as it
isn't that big of a deal I just queued it for the next merge window.
-- Steve
next prev parent reply other threads:[~2012-09-06 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 9:04 does gcc gives a false warning in kernel/trace/trace_events_filter.c ? Toralf Förster
2012-09-05 17:08 ` Steven Rostedt
2012-09-06 16:35 ` Toralf Förster
2012-09-06 17:31 ` Steven Rostedt [this message]
2012-09-06 22:22 ` Toralf Förster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346952676.1680.44.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.